Gosec

.github/workflows/gosec-latest-checks.yaml

@@ -0,0 +1,22 @@
+name: Run Gosec
+on:
+  push: 
+    branches:
+      - gosec # for testing this workflow
+  pull_request:
+    branches:
+      - master
+jobs:
+  tests:
+    runs-on: ubuntu-latest
+    env:
+      GO111MODULE: on
+    steps:
+      - name: Checkout Source 
+        uses: actions/checkout@v2
+      - name: Download Gosec
+        run: curl -sfL https://raw.githubusercontent.com/securego/gosec/master/install.sh | sudo sh -s -- -b /usr/bin latest
+      - name: Run Gosec Security Scanner 
+        #G107: Url provided to HTTP request as taint input
+        #G109: Potential Integer overflow made by strconv.Atoi result conversion to int16/32
+        run: gosec -exclude=G107,G109 -exclude-dir=cmd/kuberhealthy ./... 

cmd/daemonset-check/Makefile

@@ -1,5 +1,5 @@
 build:
-	docker build -t kuberhealthy/daemonset-check:v2.2.1 -f Dockerfile ../../
+	docker build -t kuberhealthy/daemonset-check:v2.2.2 -f Dockerfile ../../
 
 push:
-	docker push kuberhealthy/daemonset-check:v2.2.1
+	docker push kuberhealthy/daemonset-check:v2.2.2

cmd/daemonset-check/main.go

@@ -301,7 +301,10 @@ func (dsc *Checker) Shutdown(sdDoneChan chan error) {
 	var err error
 	// if the ds is deployed, delete it
 	if dsc.DaemonSetDeployed {
-		dsc.remove()
+		err = dsc.remove()
+		if err != nil {
+			log.Infoln("Failed to remove", dsc.DaemonSetName)
+		}
 		err = dsc.waitForPodRemoval()
 	}
 

cmd/deployment-check/Makefile

@@ -1,5 +1,5 @@
 build:
-	docker build -t kuberhealthy/deployment-check:v1.4.0 -f Dockerfile ../../
+	docker build -t kuberhealthy/deployment-check:v1.4.1 -f Dockerfile ../../
 
 push:
-	docker push kuberhealthy/deployment-check:v1.4.0
+	docker push kuberhealthy/deployment-check:v1.4.1

cmd/deployment-check/run_check.go

@@ -232,8 +232,10 @@ func runDeploymentCheck() {
 	}
 
 	// Clean up!
-	cleanUp(ctx)
-
+	cleanUpError := cleanUp(ctx)
+	if cleanUpError != nil {
+		reportErrorsToKuberhealthy([]string{cleanUpError.Error()})
+	}
 	// Report to Kuberhealthy.
 	reportOKToKuberhealthy()
 }

cmd/deployment-check/service_requester.go

@@ -138,7 +138,10 @@ func getRequestBackoff(hostname string) chan RequestResult {
 			if err == nil && resp.StatusCode == http.StatusOK {
 				log.Infoln("Successfully made an HTTP request on attempt:", attempts)
 				log.Infoln("Got a", resp.StatusCode, "with a", http.MethodGet, "to", hostname)
-				resp.Body.Close()
+				closeErr := resp.Body.Close()
+				if closeErr != nil {
+					log.Debugln("Failed to close response body:", closeErr.Error())
+				}
 				requestResult.Response = resp
 				requestResultChan <- requestResult
 				return
@@ -150,7 +153,10 @@ func getRequestBackoff(hostname string) chan RequestResult {
 
 			if resp != nil {
 				log.Debugln("Got a", resp.StatusCode)
-				resp.Body.Close()
+				closeErr := resp.Body.Close()
+				if closeErr != nil {
+					log.Debugln("Failed to close response body:", closeErr.Error())
+				}
 			}
 
 			retrySleep(attempts)

cmd/http-check/Makefile

@@ -1,5 +1,5 @@
 build:
-	docker build -t kuberhealthy/http-check:v1.2.1 -f Dockerfile ../../
+	docker build -t kuberhealthy/http-check:v1.2.2 -f Dockerfile ../../
 
 push:
-	docker push kuberhealthy/http-check:v1.2.1
+	docker push kuberhealthy/http-check:v1.2.2

cmd/http-check/main.go

@@ -36,23 +36,29 @@ func main() {
 	if err != nil {
 		reportErr := fmt.Errorf("error occurred performing a " + http.MethodGet + " to " + checkURL + ": " + err.Error())
 		log.Errorln(reportErr.Error())
-		err = kh.ReportFailure([]string{reportErr.Error()})
-		if err != nil {
-			log.Fatalln("error when reporting to kuberhealthy:", err.Error())
+		reportFailureErr := kh.ReportFailure([]string{reportErr.Error()})
+		if reportFailureErr != nil {
+			log.Fatalln("error when reporting to kuberhealthy:", reportFailureErr.Error())
 		}
 		os.Exit(0)
 	}
 
 	// Check if the response status code is a 200.
 	if r.StatusCode == http.StatusOK {
 		log.Infoln("Got a", r.StatusCode, "with a", http.MethodGet, "to", checkURL)
-		kh.ReportSuccess()
+		reportSuccessErr := kh.ReportSuccess()
+		if err != nil {
+			log.Fatalln("error when reporting to kuberhealthy:", reportSuccessErr.Error())
+		}
 		os.Exit(0)
 	}
 
 	reportErr := fmt.Errorf("unable to retrieve a " + strconv.Itoa(http.StatusOK) + " from " + checkURL + " got a " + strconv.Itoa(r.StatusCode) + " instead")
 	log.Errorln(reportErr.Error())
-	kh.ReportFailure([]string{reportErr.Error()})
+	reportFailureErr := kh.ReportFailure([]string{reportErr.Error()})
+	if reportFailureErr != nil {
+		log.Fatalln("error when reporting to kuberhealthy:", reportFailureErr.Error())
+	}
 
 	os.Exit(0)
 }

cmd/resource-quota-check/Makefile

@@ -1,5 +1,5 @@
 build:
-	docker build -t kuberhealthy/resource-quota-check:v1.2.1 -f Dockerfile ../../
+	docker build -t kuberhealthy/resource-quota-check:v1.2.2 -f Dockerfile ../../
 
 push:
-	docker push kuberhealthy/resource-quota-check:v1.2.1
+	docker push kuberhealthy/resource-quota-check:v1.2.2

cmd/resource-quota-check/main.go

@@ -84,7 +84,10 @@ func main() {
 	client, err = kubeClient.Create(kubeConfigFile)
 	if err != nil {
 		errorMessage := "failed to create a kubernetes client with error: " + err.Error()
-		kh.ReportFailure([]string{errorMessage})
+		reportErr := kh.ReportFailure([]string{errorMessage})
+		if reportErr != nil {
+			log.Fatalln("error reporting failure to kuberhealthy:", reportErr.Error())
+		}
 		return
 	}
 	log.Infoln("Kubernetes client created.")
@@ -95,7 +98,10 @@ func main() {
 		r = recover()
 		if r != nil {
 			log.Infoln("Recovered panic:", r)
-			kh.ReportFailure([]string{r.(string)})
+			reportErr := kh.ReportFailure([]string{r.(string)})
+			if reportErr != nil {
+				log.Fatalln("error reporting failure to kuberhealthy:", reportErr.Error())
+			}
 		}
 	}()