Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move gosec to github action instead of dockerfile on cmd/kuberhealthy #459

Merged
merged 2 commits into from May 3, 2020

Conversation

u5surf
Copy link
Contributor

@u5surf u5surf commented May 3, 2020

Fixes: #458

manual test results

$ curl -sfL https://raw.githubusercontent.com/securego/gosec/master/install.sh | sh -s -- -b $GOPATH/bin latest
securego/gosec info checking GitHub for tag 'latest'
securego/gosec info found version: 2.2.0 for v2.2.0/darwin/amd64
securego/gosec info installed /Users/u5surf/.go/bin/gosec
$ gosec -exclude=G107,G109 ./...
[gosec] 2020/05/03 15:46:30 Including rules: default
[gosec] 2020/05/03 15:46:30 Excluding rules: G107,G109
[gosec] 2020/05/03 15:46:30 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/daemonset-check
[gosec] 2020/05/03 15:46:31 Checking package: main
[gosec] 2020/05/03 15:46:31 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/daemonset-check/main.go
[gosec] 2020/05/03 15:46:31 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/daemonset-check/util.go
[gosec] 2020/05/03 15:46:31 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/deployment-check
[gosec] 2020/05/03 15:46:32 Checking package: main
[gosec] 2020/05/03 15:46:32 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/deployment-check/deployment.go
[gosec] 2020/05/03 15:46:32 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/deployment-check/input.go
[gosec] 2020/05/03 15:46:32 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/deployment-check/main.go
[gosec] 2020/05/03 15:46:32 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/deployment-check/run_check.go
[gosec] 2020/05/03 15:46:32 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/deployment-check/service.go
[gosec] 2020/05/03 15:46:32 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/deployment-check/service_requester.go
[gosec] 2020/05/03 15:46:32 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/masterCalculation
[gosec] 2020/05/03 15:46:33 Checking package: masterCalculation
[gosec] 2020/05/03 15:46:33 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/masterCalculation/masterCalculation.go
[gosec] 2020/05/03 15:46:33 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/kubeClient
[gosec] 2020/05/03 15:46:34 Checking package: kubeClient
[gosec] 2020/05/03 15:46:34 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/kubeClient/client.go
[gosec] 2020/05/03 15:46:34 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/metrics
[gosec] 2020/05/03 15:46:34 Checking package: metrics
[gosec] 2020/05/03 15:46:34 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/metrics/exporter.go
[gosec] 2020/05/03 15:46:34 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/metrics/influxdb.go
[gosec] 2020/05/03 15:46:34 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/metrics/metrics.go
[gosec] 2020/05/03 15:46:34 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/check-reaper
[gosec] 2020/05/03 15:46:35 Checking package: main
[gosec] 2020/05/03 15:46:35 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/check-reaper/main.go
[gosec] 2020/05/03 15:46:35 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/http-check
[gosec] 2020/05/03 15:46:36 Checking package: main
[gosec] 2020/05/03 15:46:36 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/http-check/main.go
[gosec] 2020/05/03 15:46:36 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/pod-restarts-check
[gosec] 2020/05/03 15:46:36 Checking package: main
[gosec] 2020/05/03 15:46:36 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/pod-restarts-check/main.go
[gosec] 2020/05/03 15:46:36 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/pod-status-check
[gosec] 2020/05/03 15:46:37 Checking package: main
[gosec] 2020/05/03 15:46:37 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/pod-status-check/main.go
[gosec] 2020/05/03 15:46:37 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/checks/external/checkclient
[gosec] 2020/05/03 15:46:38 Checking package: checkclient
[gosec] 2020/05/03 15:46:38 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/checks/external/checkclient/main.go
[gosec] 2020/05/03 15:46:38 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/checks/external/util
[gosec] 2020/05/03 15:46:39 Checking package: util
[gosec] 2020/05/03 15:46:39 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/checks/external/util/main.go
[gosec] 2020/05/03 15:46:39 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/checks/external/status
[gosec] 2020/05/03 15:46:39 Checking package: status
[gosec] 2020/05/03 15:46:39 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/checks/external/status/main.go
[gosec] 2020/05/03 15:46:39 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/khstatecrd
[gosec] 2020/05/03 15:46:39 Checking package: khstatecrd
[gosec] 2020/05/03 15:46:39 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/khstatecrd/api.go
[gosec] 2020/05/03 15:46:39 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/khstatecrd/functions.go
[gosec] 2020/05/03 15:46:39 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/khstatecrd/register.go
[gosec] 2020/05/03 15:46:39 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/khstatecrd/statecrd.go
[gosec] 2020/05/03 15:46:39 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/khstatecrd/statecrdlist.go
[gosec] 2020/05/03 15:46:39 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/ami-check
[gosec] 2020/05/03 15:46:41 Checking package: main
[gosec] 2020/05/03 15:46:41 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/ami-check/aws_ec2.go
[gosec] 2020/05/03 15:46:41 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/ami-check/aws_s3.go
[gosec] 2020/05/03 15:46:41 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/ami-check/main.go
[gosec] 2020/05/03 15:46:41 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/ami-check/run_check.go
[gosec] 2020/05/03 15:46:41 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/http-content-check
[gosec] 2020/05/03 15:46:41 Checking package: main
[gosec] 2020/05/03 15:46:41 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/http-content-check/main.go
[gosec] 2020/05/03 15:46:41 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/kiam-check
[gosec] 2020/05/03 15:46:42 Checking package: main
[gosec] 2020/05/03 15:46:42 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/kiam-check/input.go
[gosec] 2020/05/03 15:46:42 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/kiam-check/lambda.go
[gosec] 2020/05/03 15:46:42 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/kiam-check/main.go
[gosec] 2020/05/03 15:46:42 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/kuberhealthy
[gosec] 2020/05/03 15:46:43 Checking package: main
[gosec] 2020/05/03 15:46:43 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/kuberhealthy/crd.go
[gosec] 2020/05/03 15:46:43 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/kuberhealthy/influx.go
[gosec] 2020/05/03 15:46:43 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/kuberhealthy/kuberhealthy.go
[gosec] 2020/05/03 15:46:43 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/kuberhealthy/kuberhealthyCheck.go
[gosec] 2020/05/03 15:46:43 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/kuberhealthy/main.go
[gosec] 2020/05/03 15:46:43 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/kuberhealthy/reflector.go
[gosec] 2020/05/03 15:46:43 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/kuberhealthy/util.go
[gosec] 2020/05/03 15:46:43 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/test-external-check
[gosec] 2020/05/03 15:46:44 Checking package: main
[gosec] 2020/05/03 15:46:44 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/test-external-check/main.go
[gosec] 2020/05/03 15:46:44 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/aws
[gosec] 2020/05/03 15:46:44 Checking package: awsutil
[gosec] 2020/05/03 15:46:44 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/aws/aws.go
[gosec] 2020/05/03 15:46:44 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/dns-resolution-check
[gosec] 2020/05/03 15:46:45 Checking package: main
[gosec] 2020/05/03 15:46:45 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/dns-resolution-check/main.go
[gosec] 2020/05/03 15:46:45 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/resource-quota-check
[gosec] 2020/05/03 15:46:46 Checking package: main
[gosec] 2020/05/03 15:46:46 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/resource-quota-check/input.go
[gosec] 2020/05/03 15:46:46 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/resource-quota-check/main.go
[gosec] 2020/05/03 15:46:46 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/cmd/resource-quota-check/resources.go
[gosec] 2020/05/03 15:46:46 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/checks/external
[gosec] 2020/05/03 15:46:46 Checking package: external
[gosec] 2020/05/03 15:46:46 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/checks/external/main.go
[gosec] 2020/05/03 15:46:46 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/health
[gosec] 2020/05/03 15:46:47 Checking package: health
[gosec] 2020/05/03 15:46:47 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/health/checkDetails.go
[gosec] 2020/05/03 15:46:47 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/health/state.go
[gosec] 2020/05/03 15:46:47 Import directory: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/khcheckcrd
[gosec] 2020/05/03 15:46:47 Checking package: khcheckcrd
[gosec] 2020/05/03 15:46:47 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/khcheckcrd/api.go
[gosec] 2020/05/03 15:46:47 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/khcheckcrd/check.go
[gosec] 2020/05/03 15:46:47 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/khcheckcrd/checkcrd.go
[gosec] 2020/05/03 15:46:47 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/khcheckcrd/checkcrdlist.go
[gosec] 2020/05/03 15:46:47 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/khcheckcrd/functions.go
[gosec] 2020/05/03 15:46:47 Checking file: /Users/u5surf/.go/src/github.com/Comcast/kuberhealthy/pkg/khcheckcrd/register.go
Results:


Summary:
   Files: 55
   Lines: 10025
   Nosec: 0
  Issues: 0

@jonnydawg
Copy link
Collaborator

Thanks! Looks good

@jonnydawg jonnydawg merged commit 840ac95 into kuberhealthy:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move gosec to github action instead of inline in Dockerfile
2 participants