Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move gosec to github action instead of dockerfile on cmd/kuberhealthy #459

Merged
merged 2 commits into from
May 3, 2020
Merged

Move gosec to github action instead of dockerfile on cmd/kuberhealthy #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4985700
remove gosec from the dockerfile of cmd/kuberhealthy
u5surf May 3, 2020
5768496
remove exclude-dir cmd/kuberhealthy in github action
u5surf May 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gosec-latest-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ jobs:
- name: Run Gosec Security Scanner
#G107: Url provided to HTTP request as taint input
#G109: Potential Integer overflow made by strconv.Atoi result conversion to int16/32
run: gosec -exclude=G107,G109 -exclude-dir=cmd/kuberhealthy ./...
run: gosec -exclude=G107,G109 ./...
2 changes: 0 additions & 2 deletions cmd/kuberhealthy/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
FROM golang:1.13 as builder
LABEL LOCATION="git@github.com:Comcast/kuberhealthy.git"
LABEL DESCRIPTION="Kuberhealthy - Check and expose kubernetes cluster health in detail."
RUN curl -sfL https://raw.githubusercontent.com/securego/gosec/master/install.sh | sh -s -- -b $GOPATH/bin 2.0.0
RUN mkdir /kuberhealthy

WORKDIR /go/src/github.com/Comcast/kuberhealthy/
Expand All @@ -11,7 +10,6 @@ COPY ./ ./
WORKDIR /go/src/github.com/Comcast/kuberhealthy/cmd/kuberhealthy
ENV CGO_ENABLED=0
# RUN go version
RUN gosec ./...
#RUN go test -v -short -- --debug --forceMaster
RUN go build -v -o kuberhealthy
RUN mv kuberhealthy /kuberhealthy/kuberhealthy
Expand Down