add more options for check-reaper cj #635
Conversation
| @@ -26,6 +26,7 @@ spec: | |||
| restartPolicy: OnFailure | |||
| serviceAccountName: check-reaper | |||
| concurrencyPolicy: Forbid | |||
| startingDeadlineSeconds: {{ .Values.checkReaper.startingDeadlineSeconds }} | |||
There was a problem hiding this comment.
Can we add .Values.checkReaper.startingDeadlineSeconds to the values.yaml file here? That way we don't end up templating a blank property in the spec.
There was a problem hiding this comment.
I did add the item to values.yaml and left it intentionally blank since that it the default for a cronjob. There's no way to have a default value defined that would match the same behavior as a nil value.
I was thinking of using an if-statement to only add the field when defined, but a blank spec achieves the same effect. If you think this might cause an issue rendering the template or cause undesired results, I can be a little more explicit. What do you think @integrii
There was a problem hiding this comment.
@isaaguilar super sorry for the late reply! i believe that's the way we've been enabling helm values throughout the project if there are no default values provided so it'd be great to stay consistent that way!
There was a problem hiding this comment.
I added an if-statement around startingDeadlineSeconds so blank properties remain out of the spec. Hope this is what we were looking for.
isaaguilar
force-pushed
the
check-reaper-startingDeadlineSeconds
branch
from
5068110
to
058a6b3
Compare
deploy/helm/kuberhealthy/values.yaml
Outdated
| @@ -128,3 +128,4 @@ checkReaper: | |||
| repository: kuberhealthy/check-reaper | |||
| tag: v1.4.0 | |||
| nodeSelector: {} | |||
| startingDeadlineSeconds: # Default is nil for CronJobs | |||
There was a problem hiding this comment.
similar to how we have it for deployments (https://github.com/Comcast/kuberhealthy/blob/058a6b3a3eb488547199809030aede878b13b632/deploy/helm/kuberhealthy/values.yaml#L38-L39) could you comment out this startingDeadlineSeconds:?
There was a problem hiding this comment.
Thanks for pointing this out. Forgot to update these values
isaaguilar
force-pushed
the
check-reaper-startingDeadlineSeconds
branch
from
058a6b3
to
3615352
Compare
|
@integrii pinging you since you've gotta re-review! |
|
What's the plan to make these changes available in helm deployment? The only available versions in the index is 2.1.0 and 2.2.0. None of the minor versions are available for deployment with helm. |
startingDeadlineSecondsto check-reaper's cronjob templateI've been running into issues where the check-reaper has too many missed schedules for whatever reason. I figured adding this is harmless and gives the user an option to configure this without having to patch manually.