Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom tolerations #641

Merged

Conversation

yteraoka
Copy link
Contributor

Currently, this helm chart support only fixed toleration, but I want to add the custom tolerations to kuberhealty deployment.
So I added the .Values.deployment.tolerations.

Thanks

@CLAassistant
Copy link

CLAassistant commented Sep 10, 2020

CLA assistant check
All committers have signed the CLA.

@joshulyne
Copy link
Collaborator

joshulyne commented Sep 15, 2020

@yteraoka ignore my previous comment! but looks good to me! i think what would be useful is to comment out but add tolerations: under deployment values, similar to how there are args: and priorityClassName: just so folks know that is available!

@mtougeron
Copy link
Contributor

@yteraoka / @joshulyne this will be a huge help for us too. Can't wait to see it merged!

@yteraoka
Copy link
Contributor Author

@joshulyne I added blank tolerations into values.yaml as placeholder instead of comment.

@joshulyne
Copy link
Collaborator

@joshulyne I added blank tolerations into values.yaml as placeholder instead of comment.

@yteraoka thanks for adding that! I believe we're trying to avoid using blank properties so that they remain out of the spec and just commenting it out instead. We set a precedent for that in this pr: #635 and we're hoping to continue that! Sorry and thanks!!

Add the custom tolerations to deployment using `.Values.deployment.tolerations`.
@yteraoka yteraoka force-pushed the feature/support-custom-tolerations branch from 1676dc1 to 46688ec Compare September 23, 2020 23:43
@yteraoka
Copy link
Contributor Author

@joshulyne I got it. I changed the blank variable to example comment. Thanks.

@joshulyne
Copy link
Collaborator

lgtm! thanks so much!!

@joshulyne joshulyne merged commit f193764 into kuberhealthy:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants