Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add err to errMessages and update required role #829

Merged

Conversation

isaaguilar
Copy link
Contributor

  • fixed updating errorMessages with err
  • fixed pod-restarts-check rbac role to be able to list events

Fixes #828

Signed-off-by: Isa Aguilar isa@aguilarstory.com

Signed-off-by: Isa Aguilar <isa@aguilarstory.com>
Copy link
Collaborator

@integrii integrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Thanks for finding and fixing this one!

@integrii integrii merged commit 7344091 into kuberhealthy:master Feb 12, 2021
integrii pushed a commit that referenced this pull request Feb 12, 2021
@integrii integrii mentioned this pull request Feb 12, 2021
joshulyne added a commit that referenced this pull request Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pod-restarts-check silently fails since role needs permissions to list events
2 participants