-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only restartChecks if pod is master for configReloader #942
Conversation
Great find! I feel like this one should go into a different place, though. Check out the This way we have a central place to manage all reloading and check start/stopping control flow... |
You could probably move the config reloader goroutine to be just above the control flow... up where there call to |
makes sense! will refactor to do so! |
// if we are master, stop, reconfigure our khchecks, and start again with the new configuration | ||
if isMaster { | ||
log.Infoln("control: Reloading external check configurations due to kuberhealthy configuration update") | ||
k.RestartChecks(ctx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@integrii should we also be restarting the Reaper -- like in the case above?
https://github.com/kuberhealthy/kuberhealthy/pull/942/files#diff-6fe2eb1bda3003e83c281ea43553e293915389e31314d523116afe24efe877e3R244
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would restart the reaper just in case. This way we are more likely to make any new configuration options that have been set for it take effect.
dc3f03b
to
ec8282b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Signed-off-by: joshulyne <joshpark118@gmail.com>
Signed-off-by: joshulyne <joshpark118@gmail.com>
update maintainers Signed-off-by: joshulyne <joshpark118@gmail.com>
update maintainers Signed-off-by: joshulyne <joshpark118@gmail.com>
Signed-off-by: joshulyne <joshpark118@gmail.com>
Signed-off-by: joshulyne <joshpark118@gmail.com>
Signed-off-by: joshulyne <joshpark118@gmail.com>
Signed-off-by: joshulyne <joshpark118@gmail.com>
Signed-off-by: joshulyne <joshpark118@gmail.com>
9ea629f
to
4f6305e
Compare
Fixes #925