-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project id to openstack wizard #1386
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1386 +/- ##
==========================================
- Coverage 73.8% 73.19% -0.61%
==========================================
Files 203 204 +1
Lines 6096 6204 +108
Branches 562 584 +22
==========================================
+ Hits 4499 4541 +42
- Misses 1370 1419 +49
- Partials 227 244 +17
Continue to review full report at Codecov.
|
Waiting for kubermatic/kubermatic#3837 to get merged, so I can adjust the logic to it. |
/retest |
/retest pull-dashboard-headless-test |
/lgtm |
LGTM label has been added. Git tree hash: 15a157374c125f77ec50befd5427f7bff911f08a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test pre-build-dashboard-image |
What this PR does / why we need it:
Added new
Project ID
field to openstack wizard.NOTE: We do not have a way to validate if provided project id is valid. In case it is not, in the create step API will throw an error saying that cloudspec is invalid. API should either allow us to validate project id first, or adjust the error message for this case.
TODO
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1311
Release note: