Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project id to openstack wizard #1386

Merged
merged 4 commits into from
Jul 19, 2019
Merged

Add project id to openstack wizard #1386

merged 4 commits into from
Jul 19, 2019

Conversation

floreks
Copy link
Contributor

@floreks floreks commented Jul 16, 2019

What this PR does / why we need it:
Added new Project ID field to openstack wizard.

NOTE: We do not have a way to validate if provided project id is valid. In case it is not, in the create step API will throw an error saying that cloudspec is invalid. API should either allow us to validate project id first, or adjust the error message for this case.

TODO

  • Add tests

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1311

Release note:

Add support for Project ID to Openstack wizard

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 16, 2019
@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #1386 into master will decrease coverage by 0.6%.
The diff coverage is 51.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1386      +/-   ##
==========================================
- Coverage    73.8%   73.19%   -0.61%     
==========================================
  Files         203      204       +1     
  Lines        6096     6204     +108     
  Branches      562      584      +22     
==========================================
+ Hits         4499     4541      +42     
- Misses       1370     1419      +49     
- Partials      227      244      +17
Impacted Files Coverage Δ
src/app/testing/fake-data/cluster.fake.ts 95.83% <ø> (ø) ⬆️
...enstack-node-data/openstack-node-data.component.ts 69.23% <25%> (-1.1%) ⬇️
src/app/core/services/wizard/provider/provider.ts 73.91% <25%> (-10.3%) ⬇️
src/app/core/services/wizard/provider/openstack.ts 62.68% <50%> (-1.25%) ⬇️
...provider-settings/openstack/openstack.component.ts 70.09% <55.55%> (-5.05%) ⬇️
src/app/shared/utils/wizard-utils/wizard-utils.ts 76.59% <0%> (-10.64%) ⬇️
.../wizard/set-datacenter/set-datacenter.component.ts 72.72% <0%> (-10.61%) ⬇️
src/app/wizard/progress/progress.component.ts 81.81% <0%> (-8.66%) ⬇️
src/app/pages/frontpage/frontpage.component.ts 70.96% <0%> (-3.23%) ⬇️
...ard/set-cluster-spec/set-cluster-spec.component.ts 84.78% <0%> (-2.18%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db33ad...069450e. Read the comment docs.

@floreks
Copy link
Contributor Author

floreks commented Jul 17, 2019

Waiting for kubermatic/kubermatic#3837 to get merged, so I can adjust the logic to it.

@floreks floreks changed the title [WIP] Add project id to openstack wizard Add project id to openstack wizard Jul 17, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2019
@floreks
Copy link
Contributor Author

floreks commented Jul 17, 2019

/retest

@floreks
Copy link
Contributor Author

floreks commented Jul 17, 2019

/retest pull-dashboard-headless-test

@maciaszczykm
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 15a157374c125f77ec50befd5427f7bff911f08a

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2019
@floreks
Copy link
Contributor Author

floreks commented Jul 19, 2019

/retest

@floreks
Copy link
Contributor Author

floreks commented Jul 19, 2019

/test pre-build-dashboard-image

@kubermatic-bot kubermatic-bot merged commit a0fd94b into master Jul 19, 2019
@kubermatic-bot kubermatic-bot deleted the feature/openstack branch July 19, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OpenStack] Allow customers to specify the tenant ID instead of the name
3 participants