Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed overview API endpoint #5213

Merged
merged 2 commits into from
Nov 11, 2022

Conversation

pkprzekwas
Copy link
Contributor

@pkprzekwas pkprzekwas commented Nov 7, 2022

What this PR does / why we need it:
Admin seed details view.

Which issue(s) this PR fixes:

Fixes #9834

What type of PR is this?
/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

New admin api endpoint for fetching seed's details.

Documentation:

https://docs.kubermatic.com/kubermatic/main/tutorials-howtos/administration/admin-panel/seed-configurations/

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs/tbd Denotes a PR that needs documentation (change) that will be done later. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/api Denotes a PR or issue as being assigned to SIG API. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #5213 (6c9b942) into main (6d399d3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5213   +/-   ##
=======================================
  Coverage   48.18%   48.18%           
=======================================
  Files         398      398           
  Lines       15390    15390           
  Branches     2748     2748           
=======================================
  Hits         7416     7416           
  Misses       7516     7516           
  Partials      458      458           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d399d3...6c9b942. Read the comment docs.

@pkprzekwas pkprzekwas changed the title [WIP] Seed overview API endpoint Seed overview API endpoint Nov 9, 2022
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2022
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ad20cc789a810f8ca781483589b5256fb34a551e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, pkprzekwas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 2dd5c5c into kubermatic:main Nov 11, 2022
@pkprzekwas pkprzekwas deleted the 9834-seed-overview branch November 14, 2022 08:31
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

creating endpoint to seed configuration
3 participants