Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project-scoped API endpoint for Hetzner #5246

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Add project-scoped API endpoint for Hetzner #5246

merged 2 commits into from
Nov 11, 2022

Conversation

embik
Copy link
Member

@embik embik commented Nov 10, 2022 •
edited
Loading

What this PR does / why we need it:
This PR add a new API endpoint for Hetzner that is project-aware, which means it is capable of using project-scoped presets (using a Preset with project restrictions via the existing API endpoints is not possible).

Which issue(s) this PR fixes:

Fixes #5128

What type of PR is this?
/kind feature
/kind api-change

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add API endpoint for Hetzner that allows using project-scoped Presets as credentials

Documentation:

NONE

@embik
Add project-scoped endpoint for Hetzner
3c344bd 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Update swagger and apiclient gen
b62fbbf 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api Denotes a PR or issue as being assigned to SIG API. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 10, 2022
@codecov
Copy link

codecov bot commented Nov 10, 2022 •
edited
Loading

Codecov Report

Merging #5246 (b62fbbf) into main (91839d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5246   +/-   ##
=======================================
  Coverage   48.18%   48.18%           
=======================================
  Files         398      398           
  Lines       15390    15390           
  Branches     2748     2748           
=======================================
  Hits         7416     7416           
  Misses       7516     7516           
  Partials      458      458

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91839d5...b62fbbf. Read the comment docs.

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9c36abc1255af38adec0a4dacd52ecbe93f343e6

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2022
@kubermatic-bot kubermatic-bot merged commit 9cfb384 into kubermatic:main Nov 11, 2022
@embik embik deleted the project-scope-endpoints-hetzner branch November 11, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@pkprzekwas pkprzekwas Awaiting requested review from pkprzekwas

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add project-scoped API endpoints for Hetzner
3 participants
@embik @kubermatic-bot @ahmedwaleedmalik