Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project-scoped API endpoints for GCP #5330

Merged
merged 25 commits into from
Dec 5, 2022
Merged

Add project-scoped API endpoints for GCP #5330

merged 25 commits into from
Dec 5, 2022

Conversation

shatoboar
Copy link
Contributor

@shatoboar shatoboar commented Nov 23, 2022 •
edited by embik
Loading

What this PR does / why we need it:
This PR Adds a project-scoped API for GCP as described in the issue #5132
Which issue(s) this PR fixes:

Fixes #5132

What type of PR is this?

/kind api-change

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add API endpoints for GCP that allow using project-scoped Presets as credentials

Documentation:

NONE

@kubermatic-bot kubermatic-bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/api Denotes a PR or issue as being assigned to SIG API. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 23, 2022
@embik embik self-assigned this Nov 23, 2022
@embik embik self-requested a review November 23, 2022 13:57
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. docs/provided Denotes a PR that has a valid documentation reference. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 23, 2022
@ahmedwaleedmalik
Copy link
Member

ahmedwaleedmalik commented Nov 23, 2022 •
edited
Loading

@shatoboar you need to update the generated API client and swagger spec. Please run the following scripts:

hack/gen-api-client.sh
hack/update-swigger.sh

embik
embik requested changes Nov 23, 2022
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple of things to improve, plus what @ahmedwaleedmalik said about updating the generated resources.

modules/api/pkg/handler/v2/provider/gcp.go Outdated Show resolved Hide resolved
modules/api/pkg/handler/v2/provider/gcp.go Show resolved Hide resolved
modules/api/pkg/handler/v2/routes_v2.go Outdated Show resolved Hide resolved
modules/api/pkg/handler/v2/routes_v2.go Outdated Show resolved Hide resolved
modules/api/pkg/handler/v2/provider/gcp.go Outdated Show resolved Hide resolved
modules/api/pkg/handler/v2/provider/gcp.go Outdated Show resolved Hide resolved
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 23, 2022
embik
embik requested changes Dec 1, 2022
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things to fix and then this should be good to go!

modules/api/pkg/handler/v2/routes_v2.go Outdated Show resolved Hide resolved
modules/api/pkg/handler/v2/routes_v2.go Outdated Show resolved Hide resolved
@embik
Copy link
Member

embik commented Dec 2, 2022

@shatoboar you'll need to update swagger and the apiclient again via the codegen scripts :)

embik
embik requested changes Dec 2, 2022
View reviewed changes
modules/api/pkg/handler/v2/routes_v2.go Outdated Show resolved Hide resolved
embik
embik approved these changes Dec 3, 2022
View reviewed changes
Copy link
Member

@embik embik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/cc @ahmedwaleedmalik

(for sig-api approval)

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 16c8ea137203a197e5cecda74d096150d50ad572

@kubermatic-bot
Copy link
Contributor

@embik: GitHub didn't allow me to request PR reviews from the following users: for, approval.

Note that only kubermatic members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/approve

/cc @ahmedwaleedmalik for sig-api approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, embik, shatoboar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2022
@kubermatic-bot kubermatic-bot merged commit 8543334 into main Dec 5, 2022
@kubermatic-bot kubermatic-bot deleted the project_scope_gcp branch December 5, 2022 06:21
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@embik embik

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add project-scoped API endpoints for GCP
4 participants
@shatoboar @ahmedwaleedmalik @embik @kubermatic-bot