-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project-scoped API endpoints for GCP #5330
Conversation
@shatoboar you need to update the generated API client and swagger spec. Please run the following scripts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a couple of things to improve, plus what @ahmedwaleedmalik said about updating the generated resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small things to fix and then this should be good to go!
@shatoboar you'll need to update swagger and the apiclient again via the codegen scripts :) |
* updated the Request struct to correctly work with swagger
becd717
to
bfeb5b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM label has been added. Git tree hash: 16c8ea137203a197e5cecda74d096150d50ad572
|
@embik: GitHub didn't allow me to request PR reviews from the following users: for, approval. Note that only kubermatic members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, embik, shatoboar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR Adds a project-scoped API for GCP as described in the issue #5132
Which issue(s) this PR fixes:
Fixes #5132
What type of PR is this?
/kind api-change
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: