Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show system applications to all users #5535

Conversation

Waseem826
Copy link
Contributor

@Waseem826 Waseem826 commented Jan 11, 2023

What this PR does / why we need it:
Show system applications on cluster details page to all users.

Which issue(s) this PR fixes:

Fixes #5532

What type of PR is this?

/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

Show system applications on cluster details page to all users.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #5535 (91e8b64) into main (1c2b0f1) will increase coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5535      +/-   ##
==========================================
+ Coverage   48.06%   48.09%   +0.03%     
==========================================
  Files         408      409       +1     
  Lines       16219    16231      +12     
  Branches     3037     3043       +6     
==========================================
+ Hits         7795     7806      +11     
- Misses       8422     8423       +1     
  Partials        2        2              
Impacted Files Coverage Δ
...pp/shared/components/application-list/component.ts 16.14% <50.00%> (-1.03%) ⬇️
...r-from-template-dialog/steps/template/component.ts 35.71% <0.00%> (-3.76%) ⬇️
modules/web/src/app/wizard/types/wizard-mode.ts 100.00% <0.00%> (ø)
...s/web/src/app/core/components/sidenav/component.ts 89.24% <0.00%> (+1.15%) ⬆️
...ents/add-cluster-from-template-dialog/component.ts 30.00% <0.00%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c2b0f1...91e8b64. Read the comment docs.

@Waseem826
Copy link
Contributor Author

/retest

Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d0216d1742e9d21e29ba7ef6dc0625c0d7fd1f01

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Waseem826
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot merged commit 249b4c4 into kubermatic:main Jan 11, 2023
@Waseem826 Waseem826 deleted the 5532-show-system-applications-to-all-users branch January 12, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show System Applications also for cluster admin users
3 participants