-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the redirect url for keycloak logout #6144
Fix the redirect url for keycloak logout #6144
Conversation
8a73d50
to
5a0bee5
Compare
5a0bee5
to
15cf262
Compare
I just have to say it, sorry, but: It's keycloak, not keyclock. Thank you. ;-) |
15cf262
to
1b31d3d
Compare
1b31d3d
to
5be1ed2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: b04aea103cdf904b430587057ce1c7a6a914c057
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmadhamzh, ahmedwaleedmalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/cherry-pick release/v2.23 |
/cherry-pick release/v2.22 |
/cherry-pick release/v2.21 |
@ahmedwaleedmalik: #6144 failed to apply on top of branch "release/v2.23":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ahmedwaleedmalik: #6144 failed to apply on top of branch "release/v2.22":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ahmedwaleedmalik: #6144 failed to apply on top of branch "release/v2.21":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ahmadhamzh You'll have to manually backport this PR to 2.23, 2.22, 2.21. Also please ensure that the documentation makes its way into those versions as well before the next patch releases. |
What this PR does / why we need it:
Starting from Keycloak 18, RP initiated logout was introduced in keycloak.
post_logout_redirect_uri
andid_token_hint
parameters are required now for logging a user out.To support this special case, we are now adding a new configuration named
oidc_provider
which will allow us to manage OIDC provider specific configurations.Which issue(s) this PR fixes:
Fixes #6127
What type of PR is this?
/kind bug