Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.23] Add OSP to the MD patch object #6267

Merged
merged 1 commit into from
Oct 12, 2023
Merged

[release/v2.23] Add OSP to the MD patch object #6267

merged 1 commit into from
Oct 12, 2023

Conversation

ahmadhamzh
Copy link
Contributor

@ahmadhamzh ahmadhamzh commented Oct 11, 2023 •
edited by Waseem826
Loading

What this PR does / why we need it:
This is a manual cherry-pick of #6264 .

/kind bug

Add operating system profile to the machine deployment patch object.

@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 11, 2023
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone Oct 11, 2023
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2023
@ahmadhamzh
Copy link
Contributor Author

/test pre-dashboard-common-verify

@kubermatic-bot kubermatic-bot added sig/api Denotes a PR or issue as being assigned to SIG API. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2023
@ahmadhamzh ahmadhamzh force-pushed the cherry-pick-6255-fix-update-osp-v2.23 branch from 84ab064 to a774bd3 Compare October 11, 2023 10:26
@kubermatic-bot kubermatic-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 11, 2023
@Waseem826 Waseem826 added the kind/bug Categorizes issue or PR as related to a bug. label Oct 11, 2023
@ahmadhamzh
Copy link
Contributor Author

/retest

Waseem826
Waseem826 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b09014b64b4b1afecd1cbc4ed3dbf21ffc3cbed3

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
@ahmadhamzh
Copy link
Contributor Author

/retest

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit 86bfbc9 into kubermatic:release/v2.23 Oct 12, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waseem826 Waseem826 Waseem826 approved these changes

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ahmadhamzh @kubermatic-bot @kubermatic-triage-bot @Waseem826 @ahmedwaleedmalik