Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KubeOneCluster v1beta2 API and remove v1alpha1 API #1649

Merged
merged 12 commits into from
Nov 29, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 29, 2021

What this PR does / why we need it:

This PR introduces the KubeOneCluster v1beta2 API. The v1beta2 API is based on the internal KubeOneCluster API as of f9fbba8.

With this PR, the KubeOneCluster API group is changed to kubeone.k8c.io (from kubeone.io).

Important: the API is considered under-development until KubeOne 1.4.0 is not released! The API will be heavily changed in the upcoming period!

The following has been done in this PR:

  • Add KubeOneCluster v1beta2 API
  • Change KubeOneCluster API group to kubeone.k8c.io (from kubeone.io)
  • Remove KubeOneCluster v1alpha1 API
  • Add Terraform integration for v1beta2 API
  • Initial migration logic for migrating from v1beta1 to v1beta2 API (only changes API version currently)
  • E2E tests can now test both v1beta1 and v1beta2 APIs
  • Make E2E tests use v1beta2 API by default
  • Add a new E2E tests job to run conformance tests on AWS using Kubernetes 1.22 and KubeOneCluster v1beta1 API

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1611

Does this PR introduce a user-facing change?:

Add KubeOneCluster v1beta2 API and remove the legacy v1beta1 API
Change the KubeOneCluster API group to kubeone.k8c.io (from kubeone.io)

/assign @kron4eg

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg November 29, 2021 12:26
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Nov 29, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 29, 2021
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b96113b335edb0a171eed4dbb93793a393de29e2

@xmudrii
Copy link
Member Author

xmudrii commented Nov 29, 2021

/retest

2 similar comments
@xmudrii
Copy link
Member Author

xmudrii commented Nov 29, 2021

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Nov 29, 2021

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Nov 29, 2021

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2021
@xmudrii
Copy link
Member Author

xmudrii commented Nov 29, 2021

/test all

@xmudrii
Copy link
Member Author

xmudrii commented Nov 29, 2021

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2021
@kubermatic-bot kubermatic-bot merged commit 8fa17d0 into master Nov 29, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Nov 29, 2021
@kubermatic-bot kubermatic-bot deleted the kubeonecluster-api-v1beta2 branch November 29, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create KubeOneCluster v1beta2 API
3 participants