-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update cluster-autoscaler addon to match upstream example #1713
Conversation
Hi @c4tz. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: c4tz <j.zink@outlook.com>
@c4tz thank you! /lgtm |
LGTM label has been added. Git tree hash: 328aa82413642fa45c8344739c909e97b1eb2abd
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: c4tz, kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Thank you for the fast responses and merging @kron4eg ! :) What about the Is this correct? If yes, wouldn't that be behaviour we want |
@c4tz given that CA has tolaration, it will be rescheduled to the control-plane node automatically in the event if it will kill the Machine where it is running and that Machine is the last worker. Should be OK. But having affinity in place wouldn't harm anyway. |
What this PR does / why we need it:
Most importantly: Adds permissions to watch
csistoragecapacities
,csidrivers
andnamespaces
objects, reducing errors such as:Also, it adds labels to the ClusterRole, ClusterRoleBinding, etc. for better filtering as done in the offiicial cluster-autoscaler example for Hetzner.
Which issue(s) this PR fixes:
None, created this PR directly instead of opening an issue first.
Special notes for your reviewer:
I'm not quite sure whether it makes sense to also add the
affinity
bit to the deployment aswell:Does this PR introduce a user-facing change?:
No.