Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node affinity for cluster-autoscaler #1716

Merged
merged 1 commit into from
Jan 4, 2022
Merged

add node affinity for cluster-autoscaler #1716

merged 1 commit into from
Jan 4, 2022

Conversation

c4tz
Copy link
Contributor

@c4tz c4tz commented Jan 4, 2022

What this PR does / why we need it:
As discussed in #1713, it adds node affinity to the cluster-autoscaler addon.

Which issue(s) this PR fixes: None

Special notes for your reviewer: -

Does this PR introduce a user-facing change?: No.

NONE

Signed-off-by: c4tz <j.zink@outlook.com>
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jan 4, 2022
@kubermatic-bot
Copy link
Contributor

Hi @c4tz. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 4, 2022
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0d7f5a5364479aadd60cc5aa5f23a99c75977d18

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2022
@xmudrii
Copy link
Member

xmudrii commented Jan 4, 2022

/retest

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c4tz, kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member

xmudrii commented Jan 4, 2022

/retest

1 similar comment
@xmudrii
Copy link
Member

xmudrii commented Jan 4, 2022

/retest

@kubermatic-bot kubermatic-bot merged commit 9384375 into kubermatic:master Jan 4, 2022
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants