Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DigitalOcean CSI driver #1754

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Add DigitalOcean CSI driver #1754

merged 3 commits into from
Jan 25, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jan 25, 2022

What this PR does / why we need it:

This PR:

  • Adds the DigitalOcean CSI driver. The CSI driver is deployed automatically if .cloudProvider.external is enabled
  • Adds the default StorageClass and VolumeSnapshotClass for the DigitalOcean CSI driver. The StorageClass and VolumeSnapshotClass can be deployed by enabling the default-storage-class embedded addon

The following manifest has been used for testing:

---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: csi-pvc-do
spec:
  accessModes:
  - ReadWriteOnce
  resources:
    requests:
      storage: 1Gi
  storageClassName: do-block-storage
---
apiVersion: v1
kind: Pod
metadata:
  name: nginx
spec:
  containers:
  - image: nginx
    imagePullPolicy: IfNotPresent
    name: nginx
    ports:
    - containerPort: 80
      protocol: TCP
    volumeMounts:
      - mountPath: /var/lib/www/html
        name: csi-data-do
  volumes:
  - name: csi-data-do
    persistentVolumeClaim:
      claimName: csi-pvc-do
      readOnly: false

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #1710

Does this PR introduce a user-facing change?:

Add the DigitalOcean CSI driver. The CSI driver is deployed automatically if `.cloudProvider.external` is enabled
Add the default StorageClass and VolumeSnapshotClass for the DigitalOcean CSI driver. The StorageClass and VolumeSnapshotClass can be deployed by enabling the default-storage-class embedded addon

/assign @kron4eg

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg January 25, 2022 11:16
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jan 25, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 25, 2022
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 61dcba7f2922c03f6cf82cb2a796b635b292cbe2

@kubermatic-bot kubermatic-bot merged commit 2f48959 into master Jan 25, 2022
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Jan 25, 2022
@kubermatic-bot kubermatic-bot deleted the digitalocean-csi branch January 25, 2022 11:59
@kron4eg
Copy link
Member

kron4eg commented Feb 7, 2022

@xmudrii how do you think, should we update again? there is new release v4.0.0

@xmudrii
Copy link
Member Author

xmudrii commented Feb 8, 2022

@kron4eg I don't think it matters much, but I'll create a PR anyways.

@xmudrii
Copy link
Member Author

xmudrii commented Feb 8, 2022

Created #1820 to update the CSI driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants