Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.4] config: Unmarshal to versioned KubeOneCluster #1861

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #1860

/assign xmudrii

Fix an issue with `kubeone config migrate` failing to migrate configs with the `containerRuntime` block

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 17, 2022
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Feb 17, 2022
@kubermatic-bot kubermatic-bot added the dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. label Feb 17, 2022
@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 17, 2022
@xmudrii
Copy link
Member

xmudrii commented Feb 17, 2022

/retest

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2022
@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: f5808cabb9feab82270073b3223666f8f9f0c73a

@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kubermatic-bot, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2022
@kubermatic-bot kubermatic-bot merged commit a2162c4 into kubermatic:release/v1.4 Feb 17, 2022
@kubermatic-bot kubermatic-bot deleted the cherry-pick-1860-to-release/v1.4 branch October 4, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants