Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.5] Use smaller instances for AWS E2E tests and rename generate-internal-groups to update-codegen #2450

Merged
merged 7 commits into from
Nov 7, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 7, 2022

What this PR does / why we need it:

This PR is a manual cherry-pick of #2415, #2423, #2424 (partial), and #2433.

What type of PR is this?

/kind cleanup

Does this PR introduce a user-facing change? Then add your Release Note here:

- Make volume size for worker nodes configurable in Terraform configs for AWS (50 GB by default)
- Rename `generate-internal-groups` Make target to `update-codegen`

Documentation:

NONE

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg November 7, 2022 15:23
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2022
@kron4eg
Copy link
Member

kron4eg commented Nov 7, 2022

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0635c95c184edf0d1f3db76f2f99affe1b3f9c94

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Nov 7, 2022

/test all

@xmudrii
Copy link
Member Author

xmudrii commented Nov 7, 2022

/test pull-kubeone-e2e-aws-default-install-containerd-v1.24.3

@kubermatic-bot kubermatic-bot merged commit 405d4d6 into release/v1.5 Nov 7, 2022
@kubermatic-bot kubermatic-bot deleted the aws-tests-cp branch November 7, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants