Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename generate-internal-groups Make target to update-codegen #2433

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Rename generate-internal-groups Make target to update-codegen #2433

merged 1 commit into from
Nov 1, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Oct 31, 2022

What this PR does / why we need it:

This PR renames generate-internal-groups Make target to update-codegen. The script itself is called update-codegen.sh and generate-internal-groups is not really intuitive and easy to remember, so we decided to rename the Make target.

What type of PR is this?

/kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

Rename `generate-internal-groups` Make target to `update-codegen`

Documentation:

NONE

@xmudrii
Rename generate-internal-groups Make target to update-codegen
7bd6e3e 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg October 31, 2022 20:02
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/chore Updating grunt tasks etc; no production code changes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2022
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e6ffe625bd4a01f33b486662765eac8b852ad407

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2022
@kubermatic-bot kubermatic-bot merged commit 71ba701 into main Nov 1, 2022
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.6 milestone Nov 1, 2022
@kubermatic-bot kubermatic-bot deleted the make-update-codegen branch November 1, 2022 06:11
@kron4eg
Copy link
Member

kron4eg commented Nov 1, 2022

/approve
/lgtm

@xmudrii xmudrii added the backport-needed Denotes a PR or issue that has not been fully backported. label Nov 7, 2022
@xmudrii xmudrii mentioned this pull request Nov 7, 2022
Merged
@xmudrii xmudrii added backport-complete Denotes a PR or issue which has been fully backported to all required release branches. and removed backport-needed Denotes a PR or issue that has not been fully backported. labels Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-complete Denotes a PR or issue which has been fully backported to all required release branches. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xmudrii @kubermatic-bot @kron4eg @ahmedwaleedmalik