Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate AzureDisk CSI Node CRB if subject is csi-azuredisk-node-sa #2972

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Migrate AzureDisk CSI Node CRB if subject is csi-azuredisk-node-sa #2972

merged 1 commit into from
Dec 18, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 27, 2023 •
edited

What this PR does / why we need it:

Delete AzureDisk's csi-azuredisk-node-secret-binding ClusterRoleBinding if RoleRef's name is csi-azuredisk-node-sa to allow upgrading KubeOne from 1.6 to 1.7.

Which issue(s) this PR fixes:
Fixes #2971

What type of PR is this?

/kind regression

Does this PR introduce a user-facing change? Then add your Release Note here:

Delete AzureDisk's `csi-azuredisk-node-secret-binding` ClusterRoleBinding if RoleRef's name is `csi-azuredisk-node-sa` to allow upgrading KubeOne from 1.6 to 1.7

Documentation:

https://github.com/kubermatic/docs/pull/1581

/assign @kron4eg @ahmedwaleedmalik

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/regression Categorizes issue or PR as related to a regression from a prior release. docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Nov 27, 2023
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 27, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Nov 27, 2023

/cherrypick release/v1.7

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.7 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member Author

xmudrii commented Nov 27, 2023

/hold

@kubermatic-bot kubermatic-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. docs/provided Denotes a PR that has a valid documentation reference. and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Nov 27, 2023
@kron4eg
Copy link
Member

kron4eg commented Nov 27, 2023

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 115566016c787ad4409d2f91290c50a193b6305d

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@xmudrii
Migrate AzureDisk CSI Node CRB if RoleRef is csi-azuredisk-node-sa
fcf5617 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Dec 18, 2023

/test pull-kubeone-e2e-azure-default-stable-upgrade-containerd-from-v1.27.7-to-v1.28.3

@kron4eg
Copy link
Member

kron4eg commented Dec 18, 2023

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ae244c7bb0137a1aa2eda3abb825b0e2a0d7d6fc

@xmudrii
Copy link
Member Author

xmudrii commented Dec 18, 2023

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2023
@kubermatic-bot kubermatic-bot merged commit 7909287 into main Dec 18, 2023
15 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.8 milestone Dec 18, 2023
@kubermatic-bot kubermatic-bot deleted the migrate-azuredisk-csi branch December 18, 2023 13:02
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #2984

In response to this:

/cherrypick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Dec 18, 2023
Merged
@xmudrii xmudrii added the backport-complete Denotes a PR or issue which has been fully backported to all required release branches. label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@kron4eg kron4eg

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-complete Denotes a PR or issue which has been fully backported to all required release branches. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.8
Development

Successfully merging this pull request may close these issues.

kubeone 1.7 upgrade - Azure - ClusterRoleBinding csi-azuredisk-node-secret-binding migration failure
5 participants
@xmudrii @kubermatic-bot @kron4eg @ahmedwaleedmalik @Waseem826