Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.7] Migrate AzureDisk CSI Node CRB if subject is csi-azuredisk-node-sa #2984

Merged
merged 1 commit into from Dec 18, 2023
Merged

[release/v1.7] Migrate AzureDisk CSI Node CRB if subject is csi-azuredisk-node-sa #2984

merged 1 commit into from Dec 18, 2023

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #2972

/assign xmudrii

Delete AzureDisk's `csi-azuredisk-node-secret-binding` ClusterRoleBinding if RoleRef's name is `csi-azuredisk-node-sa` to allow upgrading KubeOne from 1.6 to 1.7

@xmudrii
Migrate AzureDisk CSI Node CRB if RoleRef is csi-azuredisk-node-sa
352bd75 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot mentioned this pull request Dec 18, 2023
Merged
@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 18, 2023
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.7 milestone Dec 18, 2023
@kubermatic-bot kubermatic-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2023
xmudrii
xmudrii approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind regression
/lgtm
/approve

@kubermatic-bot kubermatic-bot added kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm Indicates that a PR is ready to be merged. labels Dec 18, 2023
@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: 1fa6e59dedc8565c9d5d3fdb5c9081b50adfc590

@kubermatic-bot kubermatic-bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Dec 18, 2023
@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@xmudrii xmudrii added the cherry-pick-approved Indicates a PR has been approved by release managers. label Dec 18, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 18, 2023
@kubermatic-bot kubermatic-bot merged commit 5866144 into kubermatic:release/v1.7 Dec 18, 2023
13 checks passed
@kubermatic-bot kubermatic-bot deleted the cherry-pick-2972-to-release/v1.7 branch December 18, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kubermatic-bot @xmudrii