Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default rockylinux EC2 image filter query in AWS terraform #3207

Merged
merged 1 commit into from
May 28, 2024
Merged

Fix default rockylinux EC2 image filter query in AWS terraform #3207

merged 1 commit into from
May 28, 2024

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented May 24, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind regression

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix default rockylinux EC2 image filter query in AWS terraform

Documentation:

NONE

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/regression Categorizes issue or PR as related to a regression from a prior release. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels May 24, 2024
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 24, 2024
@kron4eg
Copy link
Member Author

kron4eg commented May 24, 2024

/test pull-kubeone-e2e-aws-rockylinux-install-containerd-external-v1.29.2

@kron4eg kron4eg marked this pull request as ready for review May 24, 2024 09:13
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2024
@kron4eg
Copy link
Member Author

kron4eg commented May 24, 2024

/assign @xmudrii

@kron4eg
Fix default rockylinux EC2 image filter query
d33186f 
Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
xmudrii
xmudrii approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f5c76dbd81bd2eaaf6e48a729d2d7d308a204cd3

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
@kubermatic-bot kubermatic-bot merged commit 0ae1753 into kubermatic:main May 28, 2024
13 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.9 milestone May 28, 2024
@kron4eg kron4eg deleted the rocky-ec2 branch May 28, 2024 15:43
@kron4eg
Copy link
Member Author

kron4eg commented Jun 25, 2024

/cherrypick release/v1.8
/cherrypick release/v1.7

@kubermatic-bot kubermatic-bot mentioned this pull request Jun 25, 2024
Merged
@kubermatic-bot
Copy link
Contributor

@kron4eg: new pull request created: #3262

In response to this:

/cherrypick release/v1.8
/cherrypick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kron4eg
Copy link
Member Author

kron4eg commented Jun 25, 2024

/cherrypick release/v1.7

@kubermatic-bot kubermatic-bot mentioned this pull request Jun 25, 2024
Merged
@kubermatic-bot
Copy link
Contributor

@kron4eg: new pull request created: #3263

In response to this:

/cherrypick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii