Restore envoy.yaml in nodeport-proxy Docker image #4590
Conversation
kubermatic-bot
added
release-note
|
/assign @alvaroaleman |
|
/cherrypick release/v2.12 Why oh why is it |
|
@xrstf: once the present PR merges, I will cherry-pick it on top of release/v2.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Both of them work. |
|
@xrstf Could you manually set the expose strategy on a cluster to test this? |
|
Seems to work just fine in my test cluster. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 99d7d546912f95822cdf4fa224b7c174e639bfa0
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
/retest |
|
@xrstf: new pull request created: #4593 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
#3830 made the nodeport-proxy easier to debug, but accidentally broke the envoy Pods inside user cluster namespaces by moving the configuration into a ConfigMap.
This PR reverts the ConfigMap part of the old PR.
Does this PR introduce a user-facing change?:
/cherry-pick release/v2.12