Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use grafana-agent instead of Promtail for logging in User Clusters #11426

Merged
merged 3 commits into from
Nov 25, 2022
Merged

Use grafana-agent instead of Promtail for logging in User Clusters #11426

merged 3 commits into from
Nov 25, 2022

Conversation

wurbanski
Copy link
Contributor

@wurbanski wurbanski commented Nov 23, 2022 •
edited
Loading

What this PR does / why we need it:
This replaces Promtail inside the user cluster with grafana-agent running in logs mode.
Removes references to "Promtail" and replaces with generic "logging agent".

Which issue(s) this PR fixes:

Fixes #11384

What type of PR is this?
/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

UserCluster MLA: grafana-agent is now used instead of Promtail inside the user clusters. No action is required.

Documentation:

https://github.com/kubermatic/docs/pull/1268

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. docs/tbd Denotes a PR that needs documentation (change) that will be done later. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 23, 2022
@wurbanski wurbanski changed the title WIP: Use grafana-agent instead of Promtail for logging in User Clusters Use grafana-agent instead of Promtail for logging in User Clusters Nov 24, 2022
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2022
@rastislavs
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c1962d54196728914e7107f629ab747c5f3a5540

@xrstf
Copy link
Contributor

xrstf commented Nov 25, 2022

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rastislavs, wurbanski, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2022
@kubermatic-bot kubermatic-bot merged commit 6e2c6e1 into kubermatic:main Nov 25, 2022
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rastislavs rastislavs rastislavs left review comments

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@rastislavs rastislavs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy grafana-agent instead of promtail in user-clusters
4 participants
@wurbanski @rastislavs @kubermatic-bot @xrstf