-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to Metering 1.2.1 #13185
Bump to Metering 1.2.1 #13185
Conversation
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit, but looks good to me
/lgtm
/approve
@@ -499,6 +499,8 @@ spec: | |||
# ReportConfigurations is a map of report configuration definitions. | |||
reports: | |||
weekly: | |||
# Format is the file format of the generated report, one of "csv" or "json" (defaults to "csv"). | |||
format: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nit: if the default format is csv
, why is this not format: "csv"
?
LGTM label has been added. Git tree hash: 32b5dba039146f37f32aab9d5a432c97a783d11b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release/v2.25 |
@xrstf: new pull request created: #13227 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Metering v1.2.1 adds JSON support, new columns, nonroot runtime and updated dependencies. This PR makes the reporting format configurable in KKP and bumps the used metering version.
The new columns are added at the end of the CSV files, so I do not think this is a breaking change. Because of that I would also like to backport this PR into 2.25, the changes in 1.2.1 are just too good to keep them from users for 6 more months.
What type of PR is this?
/kind feature
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: