Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cert-manager to 0.5.2 #2658

Merged
merged 1 commit into from Jan 21, 2019
Merged

Update cert-manager to 0.5.2 #2658

merged 1 commit into from Jan 21, 2019

Conversation

alvaroaleman
Copy link
Contributor

@alvaroaleman alvaroaleman commented Jan 21, 2019

Fixes an issue where a not properly cleaned up Ingress causes the next
certificate order to fail cert-manager/cert-manager#831

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Documentation:

Release note:

Updated cert-manager to fix an issue which caused re-issuing of a certficate via the http01 challenge to fail

Fixes an issue where a not properly cleaned up Ingress causes the next
certificate order to fail cert-manager/cert-manager#831
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2019
@kron4eg
Copy link
Member

kron4eg commented Jan 21, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7671aedbf2a34d19a67886e31fdc4d24b6477625

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2019
@kubermatic-bot kubermatic-bot merged commit dcbefa0 into master Jan 21, 2019
@kubermatic-bot kubermatic-bot deleted the update-cert-manager branch January 21, 2019 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants