Anexia Provider: Utilize `Creating` state instead of blocking `Create` call #1483

marioreggiori · 2022-11-15T15:37:54Z

What this PR does / why we need it:

The machine-controller calls the providers Create method sequentially and only starts with the provisioning of another instance after Create returned without any errors. This PR changes the

Create method to not block until the VM provisioning has completed
Get method to check via the instance status whether InstanceID and ProvisioningID are set

and utilizes the Creating state until the VM is ready.

This reduces the provisioning duration of node pools with more than one replica significantly as there are now only a couple of seconds (~10s) between the provisioning starts.

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Anexia: Refactor code to reduce provisioning time for node pools with multiple replicas.

Documentation:

NONE

kubermatic-bot · 2022-11-15T15:38:06Z

Hi @marioreggiori. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ahmedwaleedmalik · 2022-11-15T20:58:02Z

/ok-to-test

ahmedwaleedmalik · 2022-11-16T06:17:32Z

Hey @marioreggiori, can you please fix the liniting errors from pull-machine-controller-lint?

level=info msg="[runner] linters took 36.340750268s with stages: goanalysis_metalinter: 36.290770629s, structcheck: 16.344µs, wastedassign: 12.051µs"
pkg/cloudprovider/provider/anexia/helper_test.go:67:6: `createSearchHandler` is unused (deadcode)
func createSearchHandler(t *testing.T, iterations int) http.HandlerFunc {

You can ignore the rest of the CI jobs.

ahmedwaleedmalik · 2022-11-16T06:17:44Z

/test pull-machine-controller-e2e-anexia

…` call Signed-off-by: Mario Schäfer <mschaefer@anexia-it.com>

ahmedwaleedmalik

/approve
/retest

kubermatic-bot · 2022-11-16T08:09:11Z

LGTM label has been added.

Git tree hash: 5cd4eebda8f307872a586b34c640eeeb6d7b55dc

kubermatic-bot · 2022-11-16T08:09:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, marioreggiori

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/cloudprovider/provider/OWNERS~~ [ahmedwaleedmalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubermatic-triage-bot · 2022-11-18T22:03:12Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubermatic-triage-bot · 2022-11-18T23:27:12Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

ahmedwaleedmalik · 2022-11-18T23:43:22Z

/hold to avoid retries.
@xrstf can you please override pull-machine-controller-e2e-vsphere

xrstf · 2022-11-21T09:36:49Z

/override pull-machine-controller-e2e-vsphere
/unhold

kubermatic-bot · 2022-11-21T09:36:57Z

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-vsphere

In response to this:

/override pull-machine-controller-e2e-vsphere
/unhold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LittleFox94 · 2022-12-07T11:18:04Z

/cherry-pick release/v1.54

kubermatic-bot · 2022-12-07T11:18:13Z

@LittleFox94: only kubermatic org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherry-pick release/v1.54

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LittleFox94 · 2022-12-07T11:18:25Z

ok, was worth a try ^^

…` call (kubermatic#1483) Signed-off-by: Mario Schäfer <mschaefer@anexia-it.com> Signed-off-by: Mario Schäfer <mschaefer@anexia-it.com>

ahmedwaleedmalik · 2022-12-07T11:35:49Z

/cherry-pick release/v1.55

kubermatic-bot · 2022-12-07T11:36:29Z

@ahmedwaleedmalik: cannot checkout release/v1.55: error checking out release/v1.55: exit status 1. output: error: pathspec 'release/v1.55' did not match any file(s) known to git

In response to this:

/cherry-pick release/v1.55

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ahmedwaleedmalik · 2022-12-07T11:51:18Z

/cherry-pick release/v1.55

kubermatic-bot · 2022-12-07T11:51:56Z

@ahmedwaleedmalik: new pull request created: #1510

In response to this:

/cherry-pick release/v1.55

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…` call (#1483) (#1509) Signed-off-by: Mario Schäfer <mschaefer@anexia-it.com> Signed-off-by: Mario Schäfer <mschaefer@anexia-it.com> Signed-off-by: Mario Schäfer <mschaefer@anexia-it.com> Co-authored-by: Mario Reggiori <git@marioreggiori.com>

ahmedwaleedmalik · 2023-01-10T14:26:16Z

/cherry-pick release/v1.45

kubermatic-bot · 2023-01-10T14:27:21Z

@ahmedwaleedmalik: #1483 failed to apply on top of branch "release/v1.45":

Applying: Anexia Provider: Utilize `Creating` state instead of blocking `Create` call
Using index info to reconstruct a base tree...
M	pkg/cloudprovider/provider/anexia/helper_test.go
M	pkg/cloudprovider/provider/anexia/instance.go
M	pkg/cloudprovider/provider/anexia/provider.go
M	pkg/cloudprovider/provider/anexia/provider_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/cloudprovider/provider/anexia/provider_test.go
CONFLICT (content): Merge conflict in pkg/cloudprovider/provider/anexia/provider_test.go
Auto-merging pkg/cloudprovider/provider/anexia/provider.go
CONFLICT (content): Merge conflict in pkg/cloudprovider/provider/anexia/provider.go
Auto-merging pkg/cloudprovider/provider/anexia/instance.go
Auto-merging pkg/cloudprovider/provider/anexia/helper_test.go
CONFLICT (content): Merge conflict in pkg/cloudprovider/provider/anexia/helper_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Anexia Provider: Utilize `Creating` state instead of blocking `Create` call
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release/v1.45

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LittleFox94 · 2023-01-10T14:27:48Z

oh noes, looks like manual PR?
@marioreggiori can you take care of this?

ahmedwaleedmalik self-requested a review November 15, 2022 20:57

kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 15, 2022

Anexia Provider: Utilize Creating state instead of blocking `Create…

2e2c7a0

…` call Signed-off-by: Mario Schäfer <mschaefer@anexia-it.com>

marioreggiori force-pushed the optimize-node-creation branch from 1cca75e to 2e2c7a0 Compare November 16, 2022 06:40

kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 16, 2022

ahmedwaleedmalik approved these changes Nov 16, 2022

View reviewed changes

kubermatic-bot assigned ahmedwaleedmalik Nov 16, 2022

kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022

kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2022

kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2022

kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2022

kubermatic-bot merged commit cdf5b1a into kubermatic:main Nov 21, 2022

LittleFox94 mentioned this pull request Dec 7, 2022

[release/v1.54] Anexia Provider: Utilize Creating state instead of blocking `Create… #1509

Merged

kubermatic-bot mentioned this pull request Dec 7, 2022

[release/v1.55] Anexia Provider: Utilize Creating state instead of blocking Create call #1510

Merged

marioreggiori mentioned this pull request Jan 23, 2023

[release/v1.45] Anexia Provider: Utilize Creating state instead of blocking Create call #1536

Merged

marioreggiori mentioned this pull request Feb 22, 2023

Anexia Provider: Postpone machine cleanup when instance is still being created #1571

Merged

LittleFox94 mentioned this pull request May 25, 2023

Anexia Provider: Utilize Creating state instead of blocking Create call anexia-it/machine-controller#10

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Anexia Provider: Utilize `Creating` state instead of blocking `Create` call #1483

Anexia Provider: Utilize `Creating` state instead of blocking `Create` call #1483

marioreggiori commented Nov 15, 2022 •

edited by ahmedwaleedmalik

Loading

kubermatic-bot commented Nov 15, 2022

ahmedwaleedmalik commented Nov 15, 2022

ahmedwaleedmalik commented Nov 16, 2022

ahmedwaleedmalik commented Nov 16, 2022

ahmedwaleedmalik left a comment

kubermatic-bot commented Nov 16, 2022

kubermatic-bot commented Nov 16, 2022

kubermatic-triage-bot commented Nov 18, 2022

kubermatic-triage-bot commented Nov 18, 2022

ahmedwaleedmalik commented Nov 18, 2022

xrstf commented Nov 21, 2022

kubermatic-bot commented Nov 21, 2022

LittleFox94 commented Dec 7, 2022

kubermatic-bot commented Dec 7, 2022

LittleFox94 commented Dec 7, 2022

ahmedwaleedmalik commented Dec 7, 2022

kubermatic-bot commented Dec 7, 2022

ahmedwaleedmalik commented Dec 7, 2022

kubermatic-bot commented Dec 7, 2022

ahmedwaleedmalik commented Jan 10, 2023

kubermatic-bot commented Jan 10, 2023

LittleFox94 commented Jan 10, 2023

Anexia Provider: Utilize Creating state instead of blocking Create call #1483

Anexia Provider: Utilize Creating state instead of blocking Create call #1483

Conversation

marioreggiori commented Nov 15, 2022 • edited by ahmedwaleedmalik Loading

kubermatic-bot commented Nov 15, 2022

ahmedwaleedmalik commented Nov 15, 2022

ahmedwaleedmalik commented Nov 16, 2022

ahmedwaleedmalik commented Nov 16, 2022

ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

kubermatic-bot commented Nov 16, 2022

kubermatic-bot commented Nov 16, 2022

kubermatic-triage-bot commented Nov 18, 2022

kubermatic-triage-bot commented Nov 18, 2022

ahmedwaleedmalik commented Nov 18, 2022

xrstf commented Nov 21, 2022

kubermatic-bot commented Nov 21, 2022

LittleFox94 commented Dec 7, 2022

kubermatic-bot commented Dec 7, 2022

LittleFox94 commented Dec 7, 2022

ahmedwaleedmalik commented Dec 7, 2022

kubermatic-bot commented Dec 7, 2022

ahmedwaleedmalik commented Dec 7, 2022

kubermatic-bot commented Dec 7, 2022

ahmedwaleedmalik commented Jan 10, 2023

kubermatic-bot commented Jan 10, 2023

LittleFox94 commented Jan 10, 2023

Anexia Provider: Utilize `Creating` state instead of blocking `Create` call #1483

Anexia Provider: Utilize `Creating` state instead of blocking `Create` call #1483

marioreggiori commented Nov 15, 2022 •

edited by ahmedwaleedmalik

Loading