Anexia Provider: Postpone machine cleanup when instance is still being created #1571
Conversation
Signed-off-by: Mario Schäfer <mschaefer@anexia-it.com>
kubermatic-bot
added
release-note
|
Hi @marioreggiori. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubermatic-bot
added
the
size/S
kubermatic-bot
added
lgtm
|
LGTM label has been added. Git tree hash: da94541ac07aaff856279db09796be108dcdab07
|
kubermatic-bot
removed
the
needs-ok-to-test
|
/assign @ahmedwaleedmalik |
|
Seems like 1.26 nodes are not coming up on Anexia. Is this something that can be fixed? Does it depend on the CCM somehow? |
There is a known incompatibility between our Flatcar nodes and Kubernetes v1.26. We are already working on a fix. |
There was a problem hiding this comment.
/approve
/hold to avoid retries
@xrstf pull-machine-controller-e2e-anexia requires an override.
kubermatic-bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, marioreggiori The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
/override pull-machine-controller-e2e-anexia |
|
@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-anexia In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/unhold |
kubermatic-bot
removed
the
do-not-merge/hold
|
@ahmedwaleedmalik could you please cherry-pick the changes onto the v1.54 release branch? Should be possible without any conflicts. |
|
/cherry-pick release/v1.54 |
|
@ahmedwaleedmalik: new pull request created: #1580 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ahmedwaleedmalik: new pull request could not be created: failed to create pull request against kubermatic/machine-controller#release/v1.54 from head kubermatic-bot:cherry-pick-1571-to-release/v1.54: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for kubermatic-bot:cherry-pick-1571-to-release/v1.54."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release/v1.56 |
|
@ahmedwaleedmalik: new pull request created: #1603 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…atic#1571) Signed-off-by: Mario Schäfer <mschaefer@anexia-it.com>
What this PR does / why we need it:
This PR fixes a race condition in the Anexia provider Cleanup method - introduced in #1483 - which occurs when a machine is deleted before the instance has been created.
What type of PR is this?
/kind bug
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: