Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vSphere: Remove tag-based handling for multiple machines with the same name #650

Merged

Conversation

alvaroaleman
Copy link
Contributor

What this PR does / why we need it:

  • Removes the tag-based handling for multiple machines with the same name, as vsphere doesn't seem to support that anyways, seen e.G. in vSphere - PoweredOff VMs cannot be reconciled #636
  • Replaces the tag-based marker used to indicate if creation was successful with a wrapper around the Create that will call Cleanup if there was an error. This is backwards-compatible (using an annotation or sth would result in all vsphere machines prior to this change getting re-created), more intuitive (no-one expects a function called GET to mutate things) and removes the need for the machine-controller to have permissions to manage tags

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

none

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2019
@kdomanski
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0a898322aa8e423e27a7d9f3f4889090aba4e2c5

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, kdomanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,kdomanski]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit e802960 into kubermatic:master Nov 8, 2019
@alvaroaleman alvaroaleman deleted the vsphere-remove-tag-handling branch November 8, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants