Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a configurable timeout for OpenStack #843

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Implement a configurable timeout for OpenStack #843

merged 1 commit into from
Nov 3, 2020

Conversation

cedi
Copy link
Contributor

@cedi cedi commented Oct 29, 2020

What this PR does / why we need it:
Make instanceReadyCheckTimeout for OpenStack Provider configurable

Which issue(s) this PR fixes
#819

Special notes for your reviewer:
This haven't been tested properly yet.
It is still work in progress.

Optional Release Note:

[action required] instanceReadyCheckTimeout `instanceReadyCheckPeriod` and `instanceReadyCheckTimeout` are now configurable to allow alternative Timeouts and Re-Tries. 120s is the default

@kubermatic-bot kubermatic-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2020
@kubermatic-bot
Copy link
Contributor

Hi @cedi. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Oct 29, 2020
kron4eg
kron4eg reviewed Oct 30, 2020
View reviewed changes
test/e2e/provisioning/all_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/provisioning/all_e2e_test.go Outdated Show resolved Hide resolved
pkg/cloudprovider/provider/openstack/provider.go Outdated Show resolved Hide resolved
@kron4eg
Copy link
Member

kron4eg commented Oct 30, 2020

Thanks @cedi!

@kron4eg
Copy link
Member

kron4eg commented Oct 30, 2020

/assign @moadqassem

moadqassem
moadqassem reviewed Oct 30, 2020
View reviewed changes
Copy link
Member

@moadqassem moadqassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cedi Thanks for the PR. The current PR introduces new helper functions in order to treat int values which got from secrets. Where I find this as a good utility to have, however, for the fields which these functions are created, shouldn't be treated that way and should be added explicitly instead of deriving them from secrets. I am not quite sure that there is a case where we have(or will have) a value which holds a sensitive information and being of a type int. Thus I would suggest to remove these helper functions.

pkg/apis/cluster/v1alpha1/conversions/testdata/machinesv1alpha1machine/openstack.yaml Outdated Show resolved Hide resolved
pkg/apis/cluster/v1alpha1/conversions/testdata/machinesv1alpha1machine/openstack.yaml Outdated Show resolved Hide resolved
pkg/apis/cluster/v1alpha1/conversions/testdata/migrated_clusterv1alpha1machine/openstack.yaml Outdated Show resolved Hide resolved
pkg/apis/cluster/v1alpha1/conversions/testdata/migrated_clusterv1alpha1machine/openstack.yaml Outdated Show resolved Hide resolved
pkg/cloudprovider/provider/openstack/provider.go Outdated Show resolved Hide resolved
pkg/cloudprovider/provider/openstack/provider.go Outdated Show resolved Hide resolved
@kubermatic-bot kubermatic-bot added dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Oct 30, 2020
@kubermatic-bot kubermatic-bot added dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Oct 30, 2020
@moadqassem
Copy link
Member

/ok-to-test

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2020
moadqassem
moadqassem requested changes Oct 30, 2020
View reviewed changes
test/e2e/provisioning/all_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/provisioning/all_e2e_test.go Outdated Show resolved Hide resolved
\#819 Implement a configurable timeout for OpenStack
8e9054e 
Make instanceReadyCheckTimeout for OpenStack Provider configurable

Signed-off-by: cedi <cedric.kienzler@gec.io>
@cedi cedi requested a review from moadqassem November 2, 2020 22:43
@moadqassem
Copy link
Member

@cedi Thank you very much for you PR.
/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6c7c57ae3ccc47fdef09319e5d91823bf70acee8

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cedi, moadqassem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2020
@kubermatic-bot kubermatic-bot merged commit b2ae6df into kubermatic:master Nov 3, 2020
@moadqassem moadqassem mentioned this pull request Nov 3, 2020
Closed
This was referenced Nov 3, 2020
Closed
Closed
@cedi cedi deleted the feature/implement_configurable_os_timeouts_master branch November 3, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

@moadqassem moadqassem Awaiting requested review from moadqassem

Assignees

@moadqassem moadqassem

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cedi @kubermatic-bot @kron4eg @moadqassem