Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alertmanager-proxy: fix compatibility with KKP 2.20 #91

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

wurbanski
Copy link
Contributor

fixes #87

@kubermatic-bot kubermatic-bot added the dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. label Apr 21, 2022
@kubermatic-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wurbanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2022
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2022
@kubermatic-bot
Copy link

LGTM label has been added.

Git tree hash: 769bc239bb3a8683c38555d597d086dc1c8640ad

@rastislavs
Copy link
Contributor

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2022
@rastislavs
Copy link
Contributor

We first need to fix MLA for 2.18 & 2.19..

@rastislavs
Copy link
Contributor

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2022
@kubermatic-bot kubermatic-bot merged commit d1a4e83 into main Apr 26, 2022
@kubermatic-bot kubermatic-bot deleted the post-2.0-fixes branch April 26, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old KKP API Group hardcoded in Alertmanager-Proxy
4 participants