Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-thread #36

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Support multi-thread #36

merged 1 commit into from
Nov 1, 2020

Conversation

ityuhui
Copy link
Member

@ityuhui ityuhui commented Oct 27, 2020 •
edited
Loading

The draft to fix #34

We can talk about the implementation here.
And some code changes will commit to openapi-generator project and merge back.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 27, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2020
@ityuhui
Copy link
Member Author

ityuhui commented Oct 27, 2020

/cc @brendandburns

@ityuhui ityuhui force-pushed the yh-multi-thread-support-experiment branch from cf33e7e to 99c0ed1 Compare October 27, 2020 13:07
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2020
@brendandburns
Copy link
Contributor

This implementation looks fine to me. What are the open questions?

@ityuhui
Copy link
Member Author

ityuhui commented Oct 29, 2020 •
edited
Loading

Hi @brendandburns

No more question except the code review.
I will create the PR for apiClient.{h,c} in openapi-generator as you have agreed to the code change.

@brendandburns
Copy link
Contributor

This looks good to me.

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2020
@ityuhui ityuhui force-pushed the yh-multi-thread-support-experiment branch from 99c0ed1 to 493a027 Compare October 31, 2020 11:03
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2020
@ityuhui ityuhui changed the title [WIP] Support multi-thread Support multi-thread Oct 31, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2020
@ityuhui
Copy link
Member Author

ityuhui commented Oct 31, 2020 •
edited
Loading

Updated the code after #37 is merged.

Hi @brendandburns
Could you please approve the new code change to trigger k8s-ci-robot to merge this PR ?

@brendandburns
Copy link
Contributor

/lgtm
/approve

We may want to add a section documenting how to do multi-threaded programming with the client.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,ityuhui]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3bdbebc into kubernetes-client:master Nov 1, 2020
@ityuhui
Copy link
Member Author

ityuhui commented Nov 2, 2020

We may want to add a section documenting how to do multi-threaded programming with the client.

Yes. I plan to address it:

  1. Add a section in README.md
  2. Add an example

@ityuhui ityuhui deleted the yh-multi-thread-support-experiment branch November 2, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Considering multi-thread environment
3 participants
@ityuhui @brendandburns @k8s-ci-robot