Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect shared/static versions of libwebsockets #93

Conversation

ahmedyarub
Copy link
Contributor

No description provided.

@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 15, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 15, 2021
@ahmedyarub
Copy link
Contributor Author

/assign @ityuhui

@brendandburns
Copy link
Contributor

This looks fine to me, but we need you to sign the CLA.

Thanks!

@ahmedyarub
Copy link
Contributor Author

I did sign it multipole times already. Is there anything else I should do?

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedyarub, brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021
@brendandburns
Copy link
Contributor

Sorry, the new EasyCLA bot confused me, trying to merge.

@brendandburns
Copy link
Contributor

@ahmedyarub looks like you may need to sign the EasyCLA too, apologies, looks like there is a migration in progress:

kubernetes/org#2778

@ahmedyarub
Copy link
Contributor Author

@ahmedyarub looks like you may need to sign the EasyCLA too, apologies, looks like there is a migration in progress:

kubernetes/org#2778

I did sign it at least 3 times in the past hours.

@mrbobbytables
Copy link
Contributor

/easycla

@mrbobbytables
Copy link
Contributor

If you did sign it, please add to the issues in this thread: kubernetes/org#3068
We're directing the LF to that issue to keep track of the various issues people are encountering

EasyCLA blocking items in this org has been addressed in this PR: kubernetes/test-infra#24381
Should hopefully deploy soonish. Sorry about that =/ Thought it was turned off for all orgs.

@k8s-ci-robot k8s-ci-robot merged commit f16ac13 into kubernetes-client:master Nov 16, 2021
@ahmedyarub ahmedyarub deleted the ay/shared_static_libwebsockets branch November 16, 2021 23:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants