Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Exec hangs #1267

Merged
merged 18 commits into from
May 1, 2023
Merged

fix: Exec hangs #1267

merged 18 commits into from
May 1, 2023

Conversation

IvanJosipovic
Copy link
Contributor

Fixes #1266

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2023
@IvanJosipovic IvanJosipovic mentioned this pull request Apr 17, 2023
Closed
@tg123 tg123 self-assigned this Apr 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@729b10c). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##             master    #1267   +/-   ##
=========================================
  Coverage          ?   69.88%           
=========================================
  Files             ?       95           
  Lines             ?     2700           
  Branches          ?        0           
=========================================
  Hits              ?     1887           
  Misses            ?      813           
  Partials          ?        0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 18, 2023
@brendandburns
Copy link
Contributor

This looks reasonable to me. Thanks for the PR!

@IvanJosipovic
Copy link
Contributor Author

IvanJosipovic commented Apr 19, 2023 •
edited
Loading

It appears that the Event based approach has a race condition, particularly on slower systems. Due to this, I reverted to the previous logic. I also implemented a timeout for the Error condition so it will no longer wait forever.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 19, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 19, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 20, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 1, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 1, 2023
@IvanJosipovic IvanJosipovic requested a review from tg123 May 1, 2023 04:27
@IvanJosipovic
Copy link
Contributor Author

I think this approach closely resembles the Go client.

tg123
tg123 reviewed May 1, 2023
View reviewed changes
Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest use timespan instead of second
then LGTM

src/KubernetesClient/KubernetesClientConfiguration.ConfigFile.cs Outdated Show resolved Hide resolved
src/KubernetesClient/KubernetesClientConfiguration.ConfigFile.cs Outdated Show resolved Hide resolved
tg123
tg123 approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IvanJosipovic, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7508ffe into kubernetes-client:master May 1, 2023
7 checks passed
@lknite lknite mentioned this pull request Jul 25, 2023
Closed
@IvanJosipovic IvanJosipovic mentioned this pull request Aug 20, 2023
Merged
@IvanJosipovic IvanJosipovic mentioned this pull request Nov 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns brendandburns left review comments

@tg123 tg123 tg123 approved these changes

Assignees

@tg123 tg123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose exec Standard error
5 participants
@IvanJosipovic @codecov-commenter @brendandburns @k8s-ci-robot @tg123