Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create codeql-analysis.yml #519

Merged
merged 4 commits into from
Nov 19, 2020
Merged

Create codeql-analysis.yml #519

merged 4 commits into from
Nov 19, 2020

Conversation

brendandburns
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 12, 2020
tg123
tg123 reviewed Nov 17, 2020
View reviewed changes
.github/workflows/codeql-analysis.yml Outdated

on:
push:
branches: [ master, brendandburns-patch-1, readme-update-bburns, test-fix-ghbuild ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private branches?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed. (sorry this file was auto-generated)

@brendandburns brendandburns reopened this Nov 17, 2020
@tg123
Copy link
Member

tg123 commented Nov 18, 2020

latest net5 was introduced last PR
as a result, build failed.

seems codeql does not support net5

@brendandburns
Copy link
Contributor Author

Looks like the fix is to add a global.json file

github/codeql-action#244

@tg123
Copy link
Member

tg123 commented Nov 19, 2020

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8003ab0 into master Nov 19, 2020
@tg123 tg123 deleted the brendandburns-patch-2 branch May 18, 2022 11:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tg123 tg123 tg123 left review comments

@krabhishek8260 krabhishek8260 Awaiting requested review from krabhishek8260

Assignees

@tg123 tg123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendandburns @k8s-ci-robot @tg123