Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0rc3 missing AutoscalingV2Api #1397

Closed
tugtugtug opened this issue Nov 8, 2023 · 3 comments
Closed

1.0.0rc3 missing AutoscalingV2Api #1397

tugtugtug opened this issue Nov 8, 2023 · 3 comments

Comments

@tugtugtug
Copy link

Describe the bug
I'm trying to migrate to the 1.0.0rc3 version of the client to avoid CVEs reported in the request lib depended by the current 0.20.0 version. But during the migration, I found several API versions are missing, e.g. the AutoscalingV2Api.

** Client Version **
e.g. 1.0.0-rc3

** Server Version **
e.g. 1.25.1

To Reproduce
Steps to reproduce the behavior:

  1. makeApiClient(k8s.AutoscalingV2Api);
  2. this is not compiling anymore as k8s.AutoscalingV2Api doesn't exist in the 1.0.0 version.

Expected behavior
I expect the 1.0.0 version to have matching API version support.

** Example Code**

let kubeConfig = new k8s.KubeConfig();
kubeConfig.loadFromDefault();
kubeConfig.makeApiClient(k8s.AutoscalingV2Api);

Environment (please complete the following information):

  • OS: [Ubuntu 22.04]
  • NodeJS Version [18]
  • Cloud runtime [NA]

Additional context
If no quick fix can be found, a workaround is welcome so we can move on with the migration.

@mstruebing
Copy link
Member

@tugtugtug This should be connected to us using an older Kubernetes version in the release-1.x branch.
I will update this probably sometime this week and cut another RC.

mstruebing added a commit that referenced this issue Dec 15, 2023
I wanted to cut another RC to potentially close
* #1420
* #1398
* #1397

but the release is erroring at the test because of the memory limit
so I moved the increased memory limit node options into the npm script
rather than the Kubernetes Javascript Client - Validation workflow
mstruebing added a commit that referenced this issue Dec 15, 2023
I wanted to cut another RC to potentially close
* #1420
* #1398
* #1397

but the release is erroring at the test because of the memory limit
so I decided to use c8 instead of nyc because when trying to remove nyc
I concluded that the memory error comes from it and its last release was
4 years ago. It works as a drop-in replacement.

https://www.npmjs.com/package/c8
@mstruebing
Copy link
Member

@tugtugtug I've published a new release 1.0.0-rc4: https://www.npmjs.com/package/@kubernetes/client-node/v/1.0.0-rc4
Could you confirm that this issue is solved in this release?

@tugtugtug
Copy link
Author

Verified resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants