cpFromPod: close writerStream synchronously

[fpm-peter]

This replicates #880 since #943 didn't solve the issue.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: fpm-peter / name: Peter (3004ae7, 6b58590, f19d855, 83c8e41, 9836d0e, 9e87d4b, 5250d14, e12234e)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fpm-peter
Once this PR has been reviewed and has the lgtm label, please assign brendandburns for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @fpm-peter!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[fpm-peter]

/hold
there is another problem. The promise doesn't resolve correctly. Will update once I've had more time to investigate

[fpm-peter]

/unhold
Promise from cpFromPod now resolves on finish.
cpToPod is still not resolving properly and has the tendency to not fully upload larger files, probably related to kubernetes/kubernetes#60140 . I'll open an issue, since I have no idea how to add --retries to exec

[brendandburns]

Looks like CI/CD tests are failing.

[fpm-peter]

I can see why the last person didn't finish the PR. With the fake websocket never actually connecting to anything, the promise cannot resolve. Just comparing the called command with the expected called command proves nothing besides that exec is working as intended which is already validated in the exec_test. The exec-websocket-return is ignored in cpFromPod since this also proves nothing but that a connection got established - which is the problem of the bug in the first place.
I didn't find anything in other tests but is there an established way to test with an actual pod?

[brendandburns]

@fpm-peter unfortunately we don't have e2e tests with a real kubernetes cluster. You could add them, similar to the ones in the Java client here: https://github.com/kubernetes-client/java/blob/master/.github/workflows/maven.yml#L67

But that is a pretty big change to force you to do to merge this PR.

Perhaps the right answer is to remove this test if it isn't validating anything?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten