Conversation
@venukarnati92: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Welcome @venukarnati92! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
47638e9
to
3fc6031
Compare
|
/assign @yliaog |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: venukarnati92 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
089897a
to
709b078
Compare
/assign @venukarnati92 |
@yliaog : Can you please review my PR and let me know if I need to make any changes. |
thanks for the pr, it looks good. now the https://github.com/kubernetes-client/python-base repo has been merged into https://github.com/kubernetes-client/python, could you please create a PR in that repo with the commits here? |
/close |
@yliaog: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind bug
What this PR does / why we need it?
async creation of custom resources (CR) using the Custom Resource Definition is failing with the following error
AttributeError: 'ApplyResult' object has no attribute 'data'
Fix for the issue:
For Async call meta_request(func) is failing because response object is different for async vs sync call.The following fix will make sure that response object is same for synchronous and asynchronous calls.
Which issue(s) this PR fixes:
kubernetes-client/python#1626
Special notes for reviewer:
Usually for all async calls we get the response when we make the following call thread.get() but incase of dynamic client async calls I don't see that behavior because of the meta_request(func) is already parsing the response.
Does this PR introduce a user-facing change?
NONE