Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Fix trailing slash on kube/config failure #388 #45

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

bran-wang
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files          11       11           
  Lines         859      859           
=======================================
  Hits          804      804           
  Misses         55       55
Impacted Files Coverage Δ
config/kube_config.py 91.86% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f02e73...bc51a01. Read the comment docs.

@bran-wang
Copy link
Contributor Author

recheck

@pokoli
Copy link
Contributor

pokoli commented Mar 6, 2018

This is related to kubernetes-client/python#388

/lgtm

@micw523
Copy link
Contributor

micw523 commented Nov 12, 2018

/check-cla
/lgtm

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. labels Nov 12, 2018
@micw523
Copy link
Contributor

micw523 commented Nov 12, 2018

/cc @roycaihw

@roycaihw
Copy link
Member

Thanks for fixing this, @bran-wang! And thanks for reviewing and reminding :)

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bran-wang, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit 879ab01 into kubernetes-client:master Nov 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants