Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest request should squash URL #688

Closed
glbyers opened this issue Nov 12, 2018 · 6 comments
Closed

rest request should squash URL #688

glbyers opened this issue Nov 12, 2018 · 6 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@glbyers
Copy link

glbyers commented Nov 12, 2018

In later versions of k8s, a request to //version is invalid, whilst a request to /version responds as expected. This appears to be an upstream bug, but it can be handled gracefully enough by simply "squashing" the URL path. ie.

scheme, netloc, path, params, query, fragment = urlparse(url)
urlunparse((scheme, netloc, re.sub(r'path, /+', '/', path), params, query, fragment))

Can it be handled gracefully here?

@roycaihw
Copy link
Member

@glbyers Could you take a look at kubernetes-client/python-base#45 to see if it solves your problem?

Besides the host url containing trailing slash in kubeconfig file, do you have any other specific cases that cause invalid url in this client package?

@glbyers
Copy link
Author

glbyers commented Nov 13, 2018

Thanks @roycaihw, I will test this tomorrow. It certainly looks like it should work around the issue (FWIW, I'd already removed the trailing / from my kubeconfig to get around this initially.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 26, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants