Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Client 12.0 to stable #1280

Merged
merged 26 commits into from
Oct 14, 2020
Merged

Update Client 12.0 to stable #1280

merged 26 commits into from
Oct 14, 2020

Conversation

palnabarun
Copy link
Member

  • Merge changes from master
  • Update constants
  • Regenerate client
  • Apply hotfixes
  • Update CHANGELOG and README

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 12, 2020
@palnabarun palnabarun mentioned this pull request Oct 12, 2020
Closed
@roycaihw
Copy link
Member

/assign

roycaihw
roycaihw reviewed Oct 14, 2020
View reviewed changes
Copy link
Member

@roycaihw roycaihw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Thanks!

changes.txt
@@ -0,0 +1,30 @@
6d64cf67 Merge pull request #1265 from kubernetes-client/dependabot/github_actions/actions/setup-python-v2.1.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file generated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. That upgrade was done by dependabot. It was enabled in #1259.

@roycaihw
Copy link
Member

Regarding the test failure kubernetes-client/python-base#215, can we exclude the python-base update (which changed the error behavior) in this stable release. We can fix and include it in the next alpha release.

iciclespider and others added 21 commits October 14, 2020 21:16
@iciclespider @palnabarun
Unittests and example for portforwarding ability added in python-base.
d12a9a5
@iciclespider @palnabarun
Rework port forwarding unittest and example.
c819a81
@iciclespider @palnabarun
Add test that checks for portforward port error return value.
b4db6d0
@iciclespider @palnabarun
Fix tox errors.
3c6e31a
@iciclespider @palnabarun
Support both python 2.7 and 3.x.
52f31ac
@iciclespider @palnabarun
Update kubernetes/base to latest master with portforwarding implement…
bccdc73 
…ation.
@iciclespider @palnabarun
Install socat on Kubernetes node for use by port forwarding.
a037380
@unki @palnabarun
remove duplicate-lines from kubernetes/README.md
3459fe2
@palnabarun
updating base for file-like config load support
fbef9f1
@palnabarun
touching readme with newline to check test validity
c343db1
@brendanburns @palnabarun
Add dependabot.
335fa5a
@palnabarun
Remove redundant release doc
7ee9dd9
@palnabarun
Update release README
fa4591f
@palnabarun
Address comments about hot issues
8c2bcc9
@sighingnow @palnabarun
Returns the created k8s objects in create_from_{dict,yaml}.
b5ec617 
Signed-off-by: Tao He <sighingnow@gmail.com>
@sighingnow @palnabarun
Fixes for code format.
0fc8aa2 
Signed-off-by: Tao He <sighingnow@gmail.com>
@dependabot @palnabarun
Bump actions/setup-python from v1 to v2.1.2
e8fb24a 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from v1 to v2.1.2.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v1...24156c2)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @palnabarun
Bump actions/setup-python from v2.1.2 to v2.1.3
84362f8 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from v2.1.2 to v2.1.3.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v2.1.2...c181ffa)

Signed-off-by: dependabot[bot] <support@github.com>
@palnabarun
Update constants to reflect 12.0.0 stable release
d7e0398 
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun
Generate updated client
96a8693 
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun
Remove tests
5a67dd9 
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
palnabarun and others added 5 commits October 14, 2020 21:20
@palnabarun
Fix custom objects API to preserve backward compatibility
ca17df6 
Reference:
- [kubernetes-client#866](kubernetes-client#866)
- [kubernetes-client#959](kubernetes-client#959)

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun
Add kubernetes.client.apis as an alias to kubernetes.client.api
1460b1f 
Reference: kubernetes-client#974

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@fabianvf @palnabarun
Add test to ensure kubernetes client threadpool is cleaned up
e745897
@palnabarun
Update CHANGELOG
29dc69c 
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun
Update README
85475c2 
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun
Copy link
Member Author

Regarding the test failure kubernetes-client/python-base#215, can we exclude the python-base update (which changed the error behavior) in this stable release. We can fix and include it in the next alpha release.

Done. 👍 Dropped the submodule update commit from the commits.

This was referenced Oct 14, 2020
Closed
Closed
@palnabarun
Copy link
Member Author

Yay!! 🎉 The tests passed. :)

@gaby gaby mentioned this pull request Oct 14, 2020
Closed
@roycaihw
Copy link
Member

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: palnabarun, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 38a0ab4 into kubernetes-client:release-12.0 Oct 14, 2020
This was referenced Mar 15, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw roycaihw left review comments

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@roycaihw roycaihw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@palnabarun @roycaihw @k8s-ci-robot @iciclespider @unki @brendanburns @sighingnow @fabianvf