New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Initialization of V2beta1HorizontalPodAutoscalerStatus #553

Open
keigohtr opened this Issue Jun 22, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@keigohtr

keigohtr commented Jun 22, 2018

When we use create_namespaced_horizontal_pod_autoscaler of AutoscalingV2beta1Api, the response always throws an exception since it doesn't set conditions in V2beta1HorizontalPodAutoscalerStatus .

Likewise, the response of read_namespaced_horizontal_pod_autoscaler throws an exception since it doesn't set current_metrics .

I will create a PR for this.

Situaltion

  • Kubernetes 1.9 via Rancher 1.6.16
  • Python 3.6.3
  • python kubernetes 5.0.0
@ackintosh

This comment has been minimized.

ackintosh commented Jun 23, 2018

#554
It might be realized by fixing the API definition:

https://github.com/kubernetes-client/python/blob/71b5abce5a4e2d747c0bb26d4eaa17eeb08f8ac5/scripts/swagger.json#L68656

      "required": [
        "currentReplicas",
        "desiredReplicas",
        "currentMetrics",
        "conditions"
      ],

Removing "currentMetrics" and "conditions" in the swagger.json ( or its original data if the json is auto-generated file) will result as same as #554 .

@keigohtr

This comment has been minimized.

keigohtr commented Jun 24, 2018

Thank you for your information. Yes we can fix this issue by hands.
I am not sure but I think this Kubernetes swagger spec is automatically generated from a code. So I believe we need to fix the original Kubernetes code for this.

@flmu

This comment has been minimized.

flmu commented Jul 19, 2018

I am facing the same issue. Are there any plans to permanently fix this problem?

Btw, the same setting can be deployed with kubectl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment