Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update submodule #1281

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Update submodule #1281

merged 1 commit into from
Oct 15, 2020

Conversation

palnabarun
Copy link
Member

Old: fd322f7
New: a5e529d

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 12, 2020
@roycaihw
Copy link
Member

/assign

This was referenced Oct 14, 2020
Closed
Merged
@roycaihw
Copy link
Member

See kubernetes-client/python-base#215. The kubernetes-client/python-base#187 changed the error raised when the discovery doc is down / not ready.

@roycaihw
Copy link
Member

kubernetes-client/python-base#215 is merged. Could you pick it up? The test should pass now.

@palnabarun
Update submodule
2910f25 
Old: fd322f7
New: 2da2b98

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun
Copy link
Member Author

@roycaihw -- this is good to go. 🙂

@roycaihw
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: palnabarun, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit d84f220 into kubernetes-client:master Oct 15, 2020
@palnabarun palnabarun deleted the update-submodule branch October 15, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@roycaihw roycaihw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@palnabarun @roycaihw @k8s-ci-robot