Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate extensions/v1beta1 deployment #888

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Deprecate extensions/v1beta1 deployment #888

merged 1 commit into from
Jul 30, 2019

Conversation

micw523
Copy link
Contributor

@micw523 micw523 commented Jul 23, 2019

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 23, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 23, 2019
@micw523 micw523 changed the title [WIP] Deprecate extensions/v1beta1 deployment Deprecate extensions/v1beta1 deployment Jul 23, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2019
@micw523
Copy link
Contributor Author

micw523 commented Jul 23, 2019

/cc @roycaihw @yliaog This should be ready to go. Let me know if you want to incorporate something else.

roycaihw
roycaihw reviewed Jul 23, 2019
View reviewed changes
examples/create_deployment.py Outdated
@@ -27,7 +27,7 @@ def main():

with open(path.join(path.dirname(__file__), "nginx-deployment.yaml")) as f:
dep = yaml.safe_load(f)
k8s_beta = client.ExtensionsV1beta1Api()
k8s_beta = client.AppsV1Api()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename k8s_beta to something that makes more sense, e.g. apps_v1. Otherwise lgtm

@micw523
Copy link
Contributor Author

micw523 commented Jul 23, 2019

Found out that deployment_example.py needs update too. Do you want to include the changes in this PR or we should do a separate one?

@roycaihw
Copy link
Member

@micw523 let's do all the extensions/v1beta1 change in one PR

@micw523
Copy link
Contributor Author

micw523 commented Jul 24, 2019

@roycaihw done. Although deployment_example.py and the Jupyter notebooks seem to be using old apis.

scottilee
scottilee reviewed Jul 25, 2019
View reviewed changes
examples/nginx-deployment.yaml
template:
metadata:
labels:
app: nginx
spec:
containers:
- name: nginx
image: nginx:1.7.9
image: nginx:1.15.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything wrong with using latest so we don't have to keep bumping it in the future? Obviously not good practice but given it's an example I think it should be fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm keeping it on pace with https://k8s.io/examples/controllers/nginx-deployment.yaml. Otherwise I don't have a good reason :/

This was referenced Jul 25, 2019
Closed
Closed
Closed
@micw523
Copy link
Contributor Author

micw523 commented Jul 30, 2019

/assign @roycaihw

@roycaihw
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micw523, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit 41971cc into kubernetes-client:master Jul 30, 2019
@micw523 micw523 deleted the update-nginx branch September 24, 2019 20:35
@roycaihw roycaihw mentioned this pull request Feb 18, 2020
Merged
fabianvf pushed a commit to fabianvf/python that referenced this pull request Feb 21, 2020
@k8s-ci-robot @fabianvf
Merge pull request kubernetes-client#888 from micw523/update-nginx
36f2129 
Deprecate extensions/v1beta1 deployment

(cherry picked from commit 41971cc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw roycaihw left review comments

@scottilee scottilee scottilee left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@roycaihw roycaihw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@micw523 @roycaihw @k8s-ci-robot @scottilee