Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cgr.dev/chainguard/wolfi-base base image #421

Closed
wants to merge 1 commit into from
Closed

Use cgr.dev/chainguard/wolfi-base base image #421

wants to merge 1 commit into from

Conversation

AnishShah
Copy link

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Chainguard Images is a collection of container images designed for minimalism and security. These images are built from the latest source every night and ensure that the vulnerabilities are addressed ASAP.

Switching to cgr.dev/chainguard/wolfi-base from alpine will help fix vulnerabilities from the base image.

Which issue(s) this PR fixes:

Fixes #402

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@AnishShah
Use cgr.dev/chainguard/wolfi-base base image
6cc5df4 
Chainguard Images is a collection of container images designed for minimalism and security. These images are built from the latest source every night and ensure that the vulnerabilities are addressed ASAP.

Switching to cgr.dev/chainguard/wolfi-base from alpine will help fix vulnerabilities from the base image.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 24, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @AnishShah!

It looks like this is your first PR to kubernetes-csi/csi-driver-host-path 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-host-path has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AnishShah
Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @AnishShah. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 24, 2023
@jingxu97 jingxu97 removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 24, 2023
@msau42
Copy link
Collaborator

msau42 commented May 24, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 24, 2023
msau42
msau42 reviewed May 24, 2023
View reviewed changes
Dockerfile
@@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM alpine
FROM cgr.dev/chainguard/wolfi-base
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The k8s project has generally recommended distroless or debian base images. Can we use one of those instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The driver uses tar for snapshots, cp for cloning and who knows what else for block volumes (fallocate, mkfs, ...)

@k8s-ci-robot
Copy link
Contributor

@AnishShah: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-csi-driver-host-distributed-on-kubernetes-1-25 6cc5df4 link false /test pull-kubernetes-csi-csi-driver-host-distributed-on-kubernetes-1-25
pull-kubernetes-csi-csi-driver-host-path-1-24-on-kubernetes-1-24 6cc5df4 link true /test pull-kubernetes-csi-csi-driver-host-path-1-24-on-kubernetes-1-24
pull-kubernetes-csi-csi-driver-host-path-1-24-test-on-kubernetes-1-24 6cc5df4 link false /test pull-kubernetes-csi-csi-driver-host-path-1-24-test-on-kubernetes-1-24
pull-kubernetes-csi-csi-driver-host-path-1-26-on-kubernetes-1-26 6cc5df4 link false /test pull-kubernetes-csi-csi-driver-host-path-1-26-on-kubernetes-1-26
pull-kubernetes-csi-csi-driver-host-path-1-26-test-on-kubernetes-1-26 6cc5df4 link false /test pull-kubernetes-csi-csi-driver-host-path-1-26-test-on-kubernetes-1-26
pull-kubernetes-csi-csi-driver-host-path-1-25-on-kubernetes-1-25 6cc5df4 link true /test pull-kubernetes-csi-csi-driver-host-path-1-25-on-kubernetes-1-25
pull-kubernetes-csi-csi-driver-host-path-1-25-test-on-kubernetes-1-25 6cc5df4 link false /test pull-kubernetes-csi-csi-driver-host-path-1-25-test-on-kubernetes-1-25

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pohly
Copy link
Contributor

pohly commented May 30, 2023

These images are built from the latest source every night and ensure that the vulnerabilities are addressed ASAP.

That doesn't help because csi-driver-host-path then still needs to be updated. I still don't see why that is needed "ASAP" - it's a demo driver for testing.

@AnishShah AnishShah closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@msau42 msau42 msau42 left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@RaunakShah RaunakShah Awaiting requested review from RaunakShah

Assignees

@xing-yang xing-yang

@jsafrane jsafrane

@msau42 msau42

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Are high vulnerabilities being addressed?
7 participants
@AnishShah @k8s-ci-robot @msau42 @pohly @jsafrane @xing-yang @jingxu97