-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cgr.dev/chainguard/wolfi-base base image #421
Conversation
Chainguard Images is a collection of container images designed for minimalism and security. These images are built from the latest source every night and ensure that the vulnerabilities are addressed ASAP. Switching to cgr.dev/chainguard/wolfi-base from alpine will help fix vulnerabilities from the base image.
Welcome @AnishShah! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AnishShah The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @AnishShah. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@@ -12,7 +12,7 @@ | |||
# See the License for the specific language governing permissions and | |||
# limitations under the License. | |||
|
|||
FROM alpine | |||
FROM cgr.dev/chainguard/wolfi-base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The k8s project has generally recommended distroless or debian base images. Can we use one of those instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The driver uses tar
for snapshots, cp
for cloning and who knows what else for block volumes (fallocate
, mkfs
, ...)
@AnishShah: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
That doesn't help because csi-driver-host-path then still needs to be updated. I still don't see why that is needed "ASAP" - it's a demo driver for testing. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Chainguard Images is a collection of container images designed for minimalism and security. These images are built from the latest source every night and ensure that the vulnerabilities are addressed ASAP.
Switching to cgr.dev/chainguard/wolfi-base from alpine will help fix vulnerabilities from the base image.
Which issue(s) this PR fixes:
Fixes #402
Special notes for your reviewer:
Does this PR introduce a user-facing change?: