Update release tool #234

fengzixu · 2020-12-31T11:51:18Z

What type of PR is this?
/kind feature
What this PR does / why we need it:

After this pr was merged, we should also update the csi-test version for csi-driver-host-path.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

fengzixu · 2020-12-31T11:51:59Z

/ok-to-test

fengzixu · 2021-01-01T03:33:05Z

/retest

fengzixu · 2021-01-01T03:33:40Z

/assign @xing-yang @pohly

fengzixu · 2021-01-01T08:54:00Z

/retest

fengzixu · 2021-01-03T07:58:13Z

/retest

pohly · 2021-01-03T09:25:56Z

We'll have to step through the full test log to determine where it fails with a non-zero exit code. The JUnit file doesn't record any failed test. I'm still out for another week, though.

Another comment: please re-do the release-tools update with git subtree --squash. We don't want to see the individual commits anymore.

2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master 3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout 9318c6c cloud build: double the timeout, now 1 hour 4ab8b15 use the tag to replace commit of csi-test 5d74e45 change the csi-test import path to v4 7dcd0a9 upgrade csi-test to v4.0.2 86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name c3a9662 allow export image name and registry name git-subtree-dir: release-tools git-subtree-split: 2bb7525

…elease-tool

pohly · 2021-01-11T09:47:43Z

Looks like appending /v4 is broken:

HEAD is now at af2d21f Merge pull request #306 from msau42/docs
Mon Jan  4 07:32:42 UTC 2021 go1.15.5 /home/prow/go/src/github.com/kubernetes-csi/csi-test/v4$ git clean -fdx
Mon Jan  4 07:32:42 UTC 2021 go1.15.5 $ go test -c -o /home/prow/go/pkg/csiprow.HvvZaqQE7w/csi-sanity github.com/kubernetes-csi/csi-test/v4/cmd/csi-sanity
go: finding module for package github.com/kubernetes-csi/csi-test/v4/cmd/csi-sanity
go: downloading github.com/kubernetes-csi/csi-test v1.1.1
go: downloading github.com/kubernetes-csi/csi-test/v4 v4.0.2
go: downloading github.com/kubernetes-csi/csi-test v2.2.0+incompatible
go: found github.com/kubernetes-csi/csi-test/v4/cmd/csi-sanity in github.com/kubernetes-csi/csi-test/v4 v4.0.2
go: downloading github.com/onsi/ginkgo v1.11.0
go: downloading github.com/google/uuid v1.1.2
go: downloading github.com/container-storage-interface/spec v1.3.0
go: downloading google.golang.org/grpc v1.34.0
go: downloading github.com/onsi/gomega v1.7.1
go: downloading gopkg.in/yaml.v2 v2.2.8
go: downloading github.com/golang/protobuf v1.4.3
go: downloading google.golang.org/protobuf v1.25.0
go: downloading golang.org/x/net v0.0.0-20201209123823-ac852fbbde11
go: downloading google.golang.org/genproto v0.0.0-20201209185603-f92720507ed4
go: downloading golang.org/x/text v0.3.4
go: downloading github.com/hpcloud/tail v1.0.0
go: downloading golang.org/x/sys v0.0.0-20201207223542-d4d67f95c62d
go: downloading gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7
go: downloading gopkg.in/fsnotify.v1 v1.4.7
?   	github.com/kubernetes-csi/csi-test/v4/cmd/csi-sanity	[no test files]
Mon Jan  4 07:33:02 UTC 2021 go1.15.5 $ /home/prow/go/pkg/csiprow.HvvZaqQE7w/csi-sanity -ginkgo.v -csi.junitfile /logs/artifacts/junit_sanity.xml -csi.endpoint dns:///172.18.0.2:30489 -csi.stagingdir /tmp/staging -csi.mountdir /tmp/mount -csi.createstagingpathcmd /home/prow/go/pkg/csiprow.HvvZaqQE7w/mkdir_in_pod.sh -csi.createmountpathcmd /home/prow/go/pkg/csiprow.HvvZaqQE7w/mkdir_in_pod.sh -csi.removestagingpathcmd /home/prow/go/pkg/csiprow.HvvZaqQE7w/rmdir_in_pod.sh -csi.removemountpathcmd /home/prow/go/pkg/csiprow.HvvZaqQE7w/rmdir_in_pod.sh
release-tools/prow.sh: line 361: /home/prow/go/pkg/csiprow.HvvZaqQE7w/csi-sanity: No such file or directory

That change had been tested (kubernetes-csi/csi-release-tools#117 (comment) -> #210) but something must have gone wrong when testing that PR because the prow.sh change is broken without any obvious test failure.

@fengzixu Please fix the issue in this PR and then port it back to csi-release-tools. I think you can simply use CSI_PROW_SANITY_IMPORT_PATH as it was before. PACKAGE_PATH probably would be a better name for it. This code pre-dates the introduction of versioned package imports 😢

fengzixu · 2021-01-16T12:33:21Z

Looks like appending /v4 is broken:

HEAD is now at af2d21f Merge pull request #306 from msau42/docs
Mon Jan  4 07:32:42 UTC 2021 go1.15.5 /home/prow/go/src/github.com/kubernetes-csi/csi-test/v4$ git clean -fdx
Mon Jan  4 07:32:42 UTC 2021 go1.15.5 $ go test -c -o /home/prow/go/pkg/csiprow.HvvZaqQE7w/csi-sanity github.com/kubernetes-csi/csi-test/v4/cmd/csi-sanity
go: finding module for package github.com/kubernetes-csi/csi-test/v4/cmd/csi-sanity
go: downloading github.com/kubernetes-csi/csi-test v1.1.1
go: downloading github.com/kubernetes-csi/csi-test/v4 v4.0.2
go: downloading github.com/kubernetes-csi/csi-test v2.2.0+incompatible
go: found github.com/kubernetes-csi/csi-test/v4/cmd/csi-sanity in github.com/kubernetes-csi/csi-test/v4 v4.0.2
go: downloading github.com/onsi/ginkgo v1.11.0
go: downloading github.com/google/uuid v1.1.2
go: downloading github.com/container-storage-interface/spec v1.3.0
go: downloading google.golang.org/grpc v1.34.0
go: downloading github.com/onsi/gomega v1.7.1
go: downloading gopkg.in/yaml.v2 v2.2.8
go: downloading github.com/golang/protobuf v1.4.3
go: downloading google.golang.org/protobuf v1.25.0
go: downloading golang.org/x/net v0.0.0-20201209123823-ac852fbbde11
go: downloading google.golang.org/genproto v0.0.0-20201209185603-f92720507ed4
go: downloading golang.org/x/text v0.3.4
go: downloading github.com/hpcloud/tail v1.0.0
go: downloading golang.org/x/sys v0.0.0-20201207223542-d4d67f95c62d
go: downloading gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7
go: downloading gopkg.in/fsnotify.v1 v1.4.7
?   	github.com/kubernetes-csi/csi-test/v4/cmd/csi-sanity	[no test files]
Mon Jan  4 07:33:02 UTC 2021 go1.15.5 $ /home/prow/go/pkg/csiprow.HvvZaqQE7w/csi-sanity -ginkgo.v -csi.junitfile /logs/artifacts/junit_sanity.xml -csi.endpoint dns:///172.18.0.2:30489 -csi.stagingdir /tmp/staging -csi.mountdir /tmp/mount -csi.createstagingpathcmd /home/prow/go/pkg/csiprow.HvvZaqQE7w/mkdir_in_pod.sh -csi.createmountpathcmd /home/prow/go/pkg/csiprow.HvvZaqQE7w/mkdir_in_pod.sh -csi.removestagingpathcmd /home/prow/go/pkg/csiprow.HvvZaqQE7w/rmdir_in_pod.sh -csi.removemountpathcmd /home/prow/go/pkg/csiprow.HvvZaqQE7w/rmdir_in_pod.sh
release-tools/prow.sh: line 361: /home/prow/go/pkg/csiprow.HvvZaqQE7w/csi-sanity: No such file or directory

That change had been tested (kubernetes-csi/csi-release-tools#117 (comment) -> #210) but something must have gone wrong when testing that PR because the prow.sh change is broken without any obvious test failure.

@fengzixu Please fix the issue in this PR and then port it back to csi-release-tools. I think you can simply use CSI_PROW_SANITY_IMPORT_PATH as it was before. PACKAGE_PATH probably would be a better name for it. This code pre-dates the introduction of versioned package imports 😢

I think even if I didn't add /v4, the ci test of this PR will not pass. Because even if we checkout csi-test to v4.0.2 version, when we run go test command, it still fetch csi-test v2.2.x

Sat Jan 16 12:04:47 UTC 2021 go1.15.5 $ git init /home/prow/go/src/github.com/kubernetes-csi/csi-test
Initialized empty Git repository in /home/prow/go/src/github.com/kubernetes-csi/csi-test/.git/
Sat Jan 16 12:04:47 UTC 2021 go1.15.5 /home/prow/go/src/github.com/kubernetes-csi/csi-test$ git fetch --depth=1 https://github.com/kubernetes-csi/csi-test v4.0.2
From https://github.com/kubernetes-csi/csi-test
 * tag               v4.0.2     -> FETCH_HEAD
Sat Jan 16 12:04:48 UTC 2021 go1.15.5 /home/prow/go/src/github.com/kubernetes-csi/csi-test$ git checkout FETCH_HEAD
Note: checking out 'FETCH_HEAD'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at af2d21f Merge pull request #306 from msau42/docs
Sat Jan 16 12:04:48 UTC 2021 go1.15.5 /home/prow/go/src/github.com/kubernetes-csi/csi-test$ git clean -fdx
Sat Jan 16 12:04:48 UTC 2021 go1.15.5 $ go test -c -o /home/prow/go/pkg/csiprow.1UdCqheJ9R/csi-sanity github.com/kubernetes-csi/csi-test/cmd/csi-sanity
go: finding module for package github.com/kubernetes-csi/csi-test/cmd/csi-sanity
go: downloading github.com/kubernetes-csi/csi-test v1.1.1
go: downloading github.com/kubernetes-csi/csi-test v2.2.0+incompatible
go: found github.com/kubernetes-csi/csi-test/cmd/csi-sanity in github.com/kubernetes-csi/csi-test v2.2.0+incompatible
go: downloading github.com/onsi/ginkgo v1.11.0
go: downloading github.com/onsi/gomega v1.7.0
go: downloading google.golang.org/grpc v1.34.0
go: downloading gopkg.in/yaml.v2 v2.2.8
go: downloading github.com/google/uuid v1.1.2
go: downloading github.com/container-storage-interface/spec v1.3.0
go: downloading github.com/golang/protobuf v1.4.3
go: downloading github.com/hpcloud/tail v1.0.0
go: downloading golang.org/x/net v0.0.0-20201209123823-ac852fbbde11
go: downloading google.golang.org/protobuf v1.25.0
go: downloading google.golang.org/genproto v0.0.0-20201209185603-f92720507ed4
go: downloading golang.org/x/text v0.3.4
go: downloading gopkg.in/fsnotify.v1 v1.4.7
go: downloading golang.org/x/sys v0.0.0-20201207223542-d4d67f95c62d
go: downloading gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7
Sat Jan 16 12:05:02 UTC 2021 go1.15.5 $ /home/prow/go/pkg/csiprow.1UdCqheJ9R/csi-sanity -ginkgo.v -csi.junitfile /logs/artifacts/junit_sanity.xml -csi.endpoint dns:///172.18.0.4:30572 -csi.stagingdir /tmp/staging -csi.mountdir /tmp/mount -csi.createstagingpathcmd /home/prow/go/pkg/csiprow.1UdCqheJ9R/mkdir_in_pod.sh -csi.createmountpathcmd /home/prow/go/pkg/csiprow.1UdCqheJ9R/mkdir_in_pod.sh -csi.removestagingpathcmd /home/prow/go/pkg/csiprow.1UdCqheJ9R/rmdir_in_pod.sh -csi.removemountpathcmd /home/prow/go/pkg/csiprow.1UdCqheJ9R/rmdir_in_pod.sh

@pohly

pohly · 2021-01-17T14:36:20Z

Instead of go test -c -o /home/prow/go/pkg/csiprow.1UdCqheJ9R/csi-sanity github.com/kubernetes-csi/csi-test/cmd/csi-sanity we have to use go test -c -o /home/prow/go/pkg/csiprow.1UdCqheJ9R/csi-sanity ./cmd/csi-sanity and run that command in the directory where we checked out csi-test.

fengzixu · 2021-01-19T04:14:22Z

@pohly I two issues in prow.sh script is

there is no test file under /csi-test/cmd/csi-sanity in v4.0.2 version. It was old code in v2.2.0. In that case, we should use go test -c to build binary file of csi-sanity https://github.com/kubernetes-csi/csi-driver-host-path/blob/master/release-tools/prow.sh#L883
fetch csi-test from upstream always

In that case, I modified the logic in prow.sh, we need to build binary file of csi-sanity and move it to the target directory

git_checkout "${CSI_PROW_SANITY_REPO}" "${GOPATH}/src/${CSI_PROW_SANITY_PACKAGE_PATH}" "${CSI_PROW_SANITY_VERSION}" --depth=1 || die "checking out csi-sanity failed"
cd "${GOPATH}/src/${CSI_PROW_SANITY_PACKAGE_PATH}/cmd/csi-sanity" && go build || die "building csi-sanity failed"
mv ./csi-sanity "${CSI_PROW_WORK}"

This change above has been tested in https://github.com/kubernetes-csi/csi-driver-host-path/pull/210/files

Fixing PR: https://github.com/kubernetes-csi/csi-release-tools/pull/128/files @pohly @xing-yang

pohly · 2021-01-19T16:30:35Z

release-tools/prow.sh

-    git_checkout "${CSI_PROW_SANITY_REPO}" "${GOPATH}/src/${CSI_PROW_SANITY_IMPORT_PATH}" "${CSI_PROW_SANITY_VERSION}" --depth=1 || die "checking out csi-sanity failed"
-    run_with_go "${CSI_PROW_GO_VERSION_SANITY}" go test -c -o "${CSI_PROW_WORK}/csi-sanity" "${CSI_PROW_SANITY_IMPORT_PATH}/cmd/csi-sanity" || die "building csi-sanity failed"
+    git_checkout "${CSI_PROW_SANITY_REPO}" "${GOPATH}/src/${CSI_PROW_SANITY_PACKAGE_PATH}" "${CSI_PROW_SANITY_VERSION}" --depth=1 || die "checking out csi-sanity failed"
+    run_with_go "${CSI_PROW_GO_VERSION_SANITY}" go test -c -o "${CSI_PROW_WORK}/csi-sanity" "${CSI_PROW_SANITY_PACKAGE_PATH}/cmd/csi-sanity" || die "building csi-sanity failed"


From https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-csi_csi-driver-host-path/234/pull-kubernetes-csi-csi-driver-host-path-1-17-on-kubernetes-1-17/1350407805189754880/build-log.txt:

Sat Jan 16 11:45:07 UTC 2021 go1.15.5 $ go test -c -o /home/prow/go/pkg/csiprow.IW3LnBgFPK/csi-sanity github.com/kubernetes-csi/csi-test/cmd/csi-sanity go: finding module for package github.com/kubernetes-csi/csi-test/cmd/csi-sanity go: downloading github.com/kubernetes-csi/csi-test v1.1.1 go: downloading github.com/kubernetes-csi/csi-test v2.2.0+incompatible go: found github.com/kubernetes-csi/csi-test/cmd/csi-sanity in github.com/kubernetes-csi/csi-test v2.2.0+incompatible go: downloading gopkg.in/yaml.v2 v2.2.8 go: downloading google.golang.org/grpc v1.34.0 go: downloading github.com/onsi/ginkgo v1.11.0 go: downloading github.com/google/uuid v1.1.2 go: downloading github.com/onsi/gomega v1.7.0 go: downloading github.com/container-storage-interface/spec v1.3.0 go: downloading golang.org/x/net v0.0.0-20201209123823-ac852fbbde11 go: downloading github.com/golang/protobuf v1.4.3 go: downloading google.golang.org/protobuf v1.25.0 go: downloading github.com/hpcloud/tail v1.0.0 go: downloading gopkg.in/fsnotify.v1 v1.4.7 go: downloading golang.org/x/text v0.3.4 go: downloading google.golang.org/genproto v0.0.0-20201209185603-f92720507ed4 go: downloading golang.org/x/sys v0.0.0-20201207223542-d4d67f95c62d go: downloading gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7

I'm pretty sure that this ignored the source that was checked out earlier. What we need to do instead is check out the source, then inside that source code directory build with a relative package path:

go build -o "${CSI_PROW_WORK}/csi-sanity" ./cmd/csi-sanity

Sorry, I'm getting confused by the number of open PRs for this.

I see that you switched to go build + mv in #210. A better solutution would be to use go build -o <target path>.

#210 is for testing if v4.0.2 can satisfy the requirement of new capability

#234 is for updating release-tool to host-path driver

But, now, we found a bug in csi-release-tool, that's reason why I submit a new PR kubernetes-csi/csi-release-tools#128

Those PRs should be merge based on the order as below

fix: fix a bug of building csi-sanity csi-release-tools#128

Run git subtree command to update Update release tool #234

Rebase change of release-tool and merge feature: support external-health-monitor #210

@pohly

fengzixu · 2021-01-20T05:02:11Z

/test pull-kubernetes-csi-csi-driver-host-path-1-19-on-kubernetes-1-19

8fdf0f78 Merge pull request kubernetes-csi#128 from fengzixu/master 1c94220d fix: fix a bug of csi-sanity a4c41e6a Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate dbd89672 verify-boilerplate.sh: fix path to script 9289fd16 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks ad29307f Make the spelling and boilerplate checks optional 5f06d024 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests 48186eba Fix spelling and boilerplate errors 71690aff Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests 981be3fe Adding spelling and boilerplate checks. git-subtree-dir: release-tools git-subtree-split: 8fdf0f78617d73fac3f8d6894c21fe74bda9d0fa

…elease-tool

pohly

/lgtm
/approve

k8s-ci-robot · 2021-01-20T10:55:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fengzixu, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~release-tools/OWNERS~~ [pohly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

f8c8cc4c Merge pull request kubernetes-csi#237 from msau42/prow b36b5bfd Merge pull request kubernetes-csi#240 from dannawang0221/upgrade-go-version adfddcc9 Merge pull request kubernetes-csi#243 from pohly/git-subtree-pull-fix c4650889 pull-test.sh: avoid "git subtree pull" error 7b175a1e Update csi-test version to v5.2.0 987c90cc Update go version to 1.21 to match k/k 2c625d41 Add script to generate patch release notes f9d5b9c0 Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version b01fd537 Bump csi-driver-host-path version up to v1.12.0 984feece Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e6059 fixed broken links of testgrid dashboard de2fba88 Merge pull request kubernetes-csi#233 from andyzhangx/andyzhangx-patch-1 cee895e1 remove windows 20H2 build since it's EOL long time ago 670bb0ef Merge pull request kubernetes-csi#229 from marosset/fix-codespell-errors 35d5e783 Merge pull request kubernetes-csi#219 from yashsingh74/update-registry 63473cc9 Merge pull request kubernetes-csi#231 from coulof/bump-go-version-1.20.5 29a5c76c Merge pull request kubernetes-csi#228 from mowangdk/chore/adopt_kubernetes_recommand_labels 8dd28211 Update cloudbuild image with go 1.20.5 1df23dba Merge pull request kubernetes-csi#230 from msau42/prow 1f92b7e7 Add ginkgo timeout to e2e tests to help catch any stuck tests 2b8b80ea fixing some codespell errors c10b6780 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions 72984ec0 chore: adopt kubernetes recommand label b0555351 Header bd0a10b6 typo c39d73c3 Add comments f6491af0 Script to verify EOL sidecar version 901bcb5a Update registry k8s.gcr.io -> registry.k8s.io git-subtree-dir: release-tools git-subtree-split: f8c8cc4c7414c11526f14649856ff8e6b8a4e67c

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 31, 2020

k8s-ci-robot requested review from msau42 and pohly December 31, 2020 11:51

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 31, 2020

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 31, 2020

k8s-ci-robot assigned pohly and xing-yang Jan 1, 2021

fengzixu added 2 commits January 4, 2021 16:26

Merge commit '7e752dfb75e69264449feaec1c46e881ae60d2fa' into update-r…

3f7d451

…elease-tool

fengzixu force-pushed the update-release-tool branch from 2765da1 to 3f7d451 Compare January 4, 2021 07:26

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2021

fengzixu force-pushed the update-release-tool branch from c3a7e56 to 1c12158 Compare January 16, 2021 11:41

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 16, 2021

pohly requested changes Jan 19, 2021

View reviewed changes

fengzixu mentioned this pull request Jan 20, 2021

fix: fix a bug of building csi-sanity kubernetes-csi/csi-release-tools#128

Merged

fengzixu force-pushed the update-release-tool branch from def906b to 3fbeb2b Compare January 20, 2021 04:44

fengzixu added 2 commits January 20, 2021 18:59

Merge commit '0b4fb1cedf3391e0e862c2308521d4f6012eaf7c' into update-r…

dc3a2b6

…elease-tool

fengzixu force-pushed the update-release-tool branch from 3fbeb2b to dc3a2b6 Compare January 20, 2021 09:59

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2021

fengzixu requested a review from pohly January 20, 2021 10:48

pohly approved these changes Jan 20, 2021

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021

k8s-ci-robot merged commit e5c8072 into kubernetes-csi:master Jan 20, 2021

xing-yang mentioned this pull request Nov 27, 2023

Update release tools #474

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update release tool #234

Update release tool #234

fengzixu commented Dec 31, 2020

fengzixu commented Dec 31, 2020

fengzixu commented Jan 1, 2021

fengzixu commented Jan 1, 2021

fengzixu commented Jan 1, 2021

fengzixu commented Jan 3, 2021

pohly commented Jan 3, 2021

pohly commented Jan 11, 2021

fengzixu commented Jan 16, 2021 •

edited

Loading

pohly commented Jan 17, 2021

fengzixu commented Jan 19, 2021 •

edited

Loading

pohly Jan 19, 2021

pohly Jan 19, 2021

fengzixu Jan 20, 2021 •

edited

Loading

fengzixu commented Jan 20, 2021

pohly left a comment

k8s-ci-robot commented Jan 20, 2021

Update release tool #234

Update release tool #234

Conversation

fengzixu commented Dec 31, 2020

fengzixu commented Dec 31, 2020

fengzixu commented Jan 1, 2021

fengzixu commented Jan 1, 2021

fengzixu commented Jan 1, 2021

fengzixu commented Jan 3, 2021

pohly commented Jan 3, 2021

pohly commented Jan 11, 2021

fengzixu commented Jan 16, 2021 • edited Loading

pohly commented Jan 17, 2021

fengzixu commented Jan 19, 2021 • edited Loading

pohly Jan 19, 2021

Choose a reason for hiding this comment

pohly Jan 19, 2021

Choose a reason for hiding this comment

fengzixu Jan 20, 2021 • edited Loading

Choose a reason for hiding this comment

fengzixu commented Jan 20, 2021

pohly left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 20, 2021

fengzixu commented Jan 16, 2021 •

edited

Loading

fengzixu commented Jan 19, 2021 •

edited

Loading

fengzixu Jan 20, 2021 •

edited

Loading